[Do Not Merge] POC using accessor interface with ccip reader. #845
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| // offRampStaticChainConfig is used to parse the response from the offRamp contract's getStaticConfig method. | ||
| // See: <chainlink repo>/contracts/src/v0.8/ccip/offRamp/OffRamp.sol:StaticConfig | ||
| type offRampStaticChainConfig struct { |
There was a problem hiding this comment.
Why are we removing those configs ? Maybe move them to ccip_interface.go ?
There was a problem hiding this comment.
This is the onchain representation of these config types. The protocol representation of them is OfframpConfig.
Types like this are what I'm referring to when I talk about "dynamic typing". In theory you could use the EVM gobindings instead of re-defining the types here, but that would break the dependency hierarchy unless you define the CAL implementations as part of the capability in the chainlink repo.
|
FYI I forked your branch here, and tried to experiment implementing the new interface with existing cr/cw |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a POC to see what ccip.go might look like if it were implemented with the accessor interface instead of managing queries directly.