[Solana] Execution buffer contract for large TX #897
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PabloMansanet
changed the title
PabloMansanet
force-pushed
the
execution-buffer
branch
2 times, most recently
from
2290a1f to
1687331
Compare
toblich
reviewed
May 7, 2025
chains/solana/contracts/programs/execution-buffer/src/context.rs
Outdated
Show resolved
Hide resolved
jadepark-dev
previously approved these changes
May 7, 2025
| ) | ||
| } | ||
|
|
||
| pub fn append_execution_report_data<'info>( |
There was a problem hiding this comment.
It looks good overall, but I'm curious if we need to implement a hard cap for the report data size on-chain? While the CPI limits would eventually act as a constraint, I'm just asking out of curiosity.
There was a problem hiding this comment.
Hmm, not sure myself, what's the worst case scenario here? Even if we promise "infinite size TX", I would imagine that users experienced with Solana will expect something to break.
Integration tests Integration tests
PabloMansanet
force-pushed
the
execution-buffer
branch
from
e1d2a5b to
04b0790
Compare
|
@toblich addressed your comments, PTAL when you can 🙏 |
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.