Skip to content

Fix multinode client issues with Geth #135

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Fix multinode client issues with Geth #135

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion build/devenv/env-geth.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,4 +8,10 @@
container_name = "blockchain-dst"
chain_id = "2337"
port = "8555"
type = "geth"
type = "geth"

[[blockchains]]
container_name = "blockchain-3rd"
chain_id = "3337"
port = "8565"
type = "geth"
2 changes: 1 addition & 1 deletion build/devenv/environment.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,7 +84,7 @@ func checkKeys(in *Cfg) error {

func NewProductConfigurationFromNetwork(typ string) (CCIP17ProductConfiguration, error) {
switch typ {
case "anvil":
case "anvil", "geth":
return &ccvEvm.CCIP17EVM{}, nil
case "canton":
// see devenv-evm implementation and add Canton
Expand Down
8 changes: 4 additions & 4 deletions common/pkg/multi_node_client.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,14 +27,14 @@ func CreateMultiNodeClientFromInfo(ctx context.Context, blockchainInfo *protocol
noNewHeadsThreshold := 3 * time.Minute
selectionMode := ptr("HighestHead")
leaseDuration := 0 * time.Second
pollFailureThreshold := ptr(uint32(5))
pollFailureThreshold := ptr(uint32(10))
pollInterval := 2 * time.Second
syncThreshold := ptr(uint32(5))
syncThreshold := ptr(uint32(10))
nodeIsSyncingEnabled := ptr(false)
chainTypeStr := blockchainInfo.Type
finalizedBlockOffset := ptr[uint32](16)
finalizedBlockOffset := ptr[uint32](1)
enforceRepeatableRead := ptr(true)
deathDeclarationDelay := time.Second * 3
deathDeclarationDelay := time.Minute * 3
noNewFinalizedBlocksThreshold := time.Second * 120
finalizedBlockPollInterval := time.Second * 10
newHeadsPollInterval := time.Second * 4
Expand Down
Loading