Skip to content

Conversation

asoliman92
Copy link
Contributor

@asoliman92 asoliman92 commented Oct 16, 2025

  • Add indexer assertions in load tests
  • Added more metrics to get more data at a glimpse
  • Remove rate limits from Aggregator - Currently causing flakes in tests.
  • Stop using ResilientReader in indexer
  • Prefixed MessageIDs with 0x during logging

@asoliman92 asoliman92 requested review from a team and skudasov as code owners October 16, 2025 13:38
Copy link

👋 asoliman92, thanks for creating this pull request!

To help reviewers, please consider creating future PRs as drafts first. This allows you to self-review and make any final changes before notifying the team.

Once you're ready, you can mark it as "Ready for review" to request feedback. Thanks!

carte7000
carte7000 previously approved these changes Oct 16, 2025
@asoliman92 asoliman92 enabled auto-merge (squash) October 16, 2025 13:46
Copy link
Contributor

@KodeyThomas KodeyThomas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we update the limits rather then remove them?

carte7000

This comment was marked as duplicate.

@carte7000 carte7000 dismissed their stale review October 16, 2025 15:06

I think the limit is reached because of pagination during load test we probably can bump the limit to 1200 or higher like Kodey suggested

carte7000
carte7000 previously approved these changes Oct 16, 2025
@asoliman92
Copy link
Contributor Author

Current page size is set to 100
and the rate limit is 90 req/minute
smth needs more investigation and in the meantime this is for sure one of the blockers while load testing

@KodeyThomas @carte7000

@asoliman92 asoliman92 marked this pull request as draft October 17, 2025 10:54
auto-merge was automatically disabled October 17, 2025 10:54

Pull request was converted to draft

carte7000
carte7000 previously approved these changes Oct 17, 2025
@asoliman92 asoliman92 changed the title Remove rate limits from Aggregator Add indexer assertions in load tests Oct 17, 2025
@asoliman92 asoliman92 marked this pull request as ready for review October 17, 2025 14:44
@asoliman92 asoliman92 enabled auto-merge (squash) October 17, 2025 14:56
@asoliman92 asoliman92 dismissed KodeyThomas’s stale review October 17, 2025 15:03

We agreed to disable circuit breakers and rate limits

Copy link

Code coverage report:

Package main asoliman/no-rate-limit-aggregator
aggregator 47.94% 47.94%
ccv-evm 0.00% 0.00%
cmd 0.00% 0.00%
executor 34.08% 34.08%
indexer 25.39% 33.56%
integration 5.03% 5.03%
protocol 42.63% 42.63%
verifier 47.54% 47.54%

@asoliman92 asoliman92 merged commit 5f1fbf9 into main Oct 17, 2025
8 of 9 checks passed
@asoliman92 asoliman92 deleted the asoliman/no-rate-limit-aggregator branch October 17, 2025 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants