build/devenv: multiple verifier and receiver deployment #199
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add Justfile recipe to do it easily for root module and build/denvenv.
* Fix extraArgs offchain encoding * Specify multiple commit verifier deployments * Specify multiple mock receiver deployments
makramkd
changed the title
makramkd
commented
Oct 18, 2025
| [committees.default.quorumConfigs.4793464827907405086] | ||
| committeeVerifierAddress = "0x9A9f2CCfdE556A7E9Ff0848998Aa4a0CFD8863AE" | ||
| threshold = 1 | ||
| threshold = 2 |
There was a problem hiding this comment.
Unifying everything for now until we figure out a better way to generate these configs from code.
0xAustinWang
previously approved these changes
Oct 18, 2025
| ChainSel: selector, | ||
| RemoteChains: remoteChains, | ||
| CommitteeVerifiers: []datastore.AddressRef{ | ||
| { |
There was a problem hiding this comment.
@RensR It would be useful to a description on the Verifier contract to identify it apart from typeandversion and direct address.
Would be a lot easier to ensure the source/dest chain verifier pair match for any given ccv
|
Code coverage report:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requires: smartcontractkit/chainlink-ccip#1298
This PR is a pre-requisite to testing messages with multiple verifiers specified. Also bumps chainlink-ccip to the version that no longer has the required/optional/threshold distinction in the extraArgs.