Ground for multi committee in aggregator #91
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
makramkd
reviewed
Sep 18, 2025
| type aggregationRequest struct { | ||
| // CommitteeID is the ID of the committee for the aggregation request. | ||
| MessageID model.MessageID | ||
| CommitteeID string |
There was a problem hiding this comment.
Is it described somewhere how this ID is generated/determined/assigned?
There was a problem hiding this comment.
The committeeID is an internal concept. I will add something to the config struct describing it but essentially it's just a name we set in the config
| }, | ||
| "12922642891491394802": { | ||
| OfframpAddress: "0x68B1D87F95878fE05B998F19b66F4baba5De1aed", | ||
| OnrampAddress: "0x959922bE3CAee4b8Cd9a407cc3ac1C251C2007B1", |
There was a problem hiding this comment.
Any reason this was deleted? Also, are these addresses (the not deleted ones) deterministic, i.e. the env will always deploy to them?
There was a problem hiding this comment.
The onramp were moved one level higher because they are specific to the committee. In the previous config we only had a 1:1 mapping possible between offramp and onramp which does not work if we have more than 2 chains
|
makramkd
approved these changes
Sep 19, 2025
bukata-sa
pushed a commit
that referenced
this pull request
Sep 24, 2025
bukata-sa
added a commit
that referenced
this pull request
Sep 24, 2025
…85) * feature: scan events outside of protocol and publish as traces to tempo * mock traces * push open spans * measure src-dest latency * lint * Cleaning up unused extra args and other structs (#90) * Cleaning up unused extra args and other structs * move ccv * Aggregator Batch Write API (#49) * Aggregator Batch Write API * Lint * CI issues * Initial Checkpoint APIs (#62) * Initial Checkpoint APIs * Linting issues * Remove redundant tests * fix: ci workflows + linting + tests (#79) * fix: enable coverage report for indexer * fix: update to new workflow * chore: run on every pr * chore: run on every pr * chore: checkout * fix: secrets issue * fix: cwd * fix: cwd * fix: cwd * chore: ugh * chore: please * chore: please * chore: please * chore: please * chore: please * chore: please * chore: please * fix: indexer linting * chore: linting * fix: indexer linting * fix: aggregator linting * chore: maybe * chore: maybe * chore: finally * fix: test ordering * Ground for multi committee in aggregator (#91) * actualize --------- Co-authored-by: Abdelrahman Soliman (Boda) <[email protected]> Co-authored-by: Simon B.Robert <[email protected]> Co-authored-by: Kodey Thomas <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.