Proposal for Custom Beholder Messages #1075
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The default custom message utility uses a `BaseMessage` proto with the message data expected to be a string and labels added to the proto message. Instead, a proto message itself can be sent where the message and schema details are packaged together by an interface. This promotes the design that any particular entity can be emitted given that it satisfies the interface.
EasterTheBunny
temporarily deployed
to
integration
GitHub Actions
Inactive
EasterTheBunny
temporarily deployed
to
integration
GitHub Actions
Inactive
EasterTheBunny
temporarily deployed
to
integration
GitHub Actions
Inactive
|
This PR is stale because it has been open 30 days with no activity. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The default custom message utility uses a
BaseMessageproto with the message data expected to be a string and labels added to the proto message.Instead, a proto message itself can be sent where the message and schema details are packaged together by an interface. This promotes the design that any particular entity can be emitted given that it satisfies the interface.
As a temporary measure, the
Emitinterface accepts ananytype to allow for existing string types or theProtoMessageinterface. This could be reworked using generics on theLabeler.One more upcoming feature of beholder is the ability to have delivery guarantees as an option. This will require mechanisms for retry, possibly with persistence. The
Labelerentity could be expanded for this use case.Requires
Supports