Skip to content

Allow unstubed methods for non-strict triggers #1178

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 9, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion pkg/workflows/sdk/v2/testutils/runner.go
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
package testutils

import (
"errors"
"io"
"log/slog"
"testing"
Expand Down Expand Up @@ -119,7 +120,9 @@ func (r *runner[T]) Run(args *sdk.WorkflowArgs[T]) {
}

response, err := trigger.InvokeTrigger(r.tb.Context(), request)
if err != nil {

var nostub ErrNoTriggerStub
if err != nil && (r.strictTriggers || !errors.As(err, &nostub)) {
r.err = err
return
}
Expand Down
81 changes: 81 additions & 0 deletions pkg/workflows/sdk/v2/testutils/runner_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -168,6 +168,46 @@ func TestRunner_MissingTriggersAreNotRequired(t *testing.T) {
require.NoError(t, err)
}

func TestRunner_MissingTriggerStubsAreNotRequired(t *testing.T) {
anyConfig := &basictrigger.Config{Name: "name", Number: 123}
anyConfig2 := &actionandtrigger.Config{Name: "b"}
anyTrigger := &basictrigger.Outputs{CoolOutput: "cool"}

trigger, err := basictriggermock.NewBasicCapability(t)
require.NoError(t, err)
trigger.Trigger = func(_ context.Context, config *basictrigger.Config) (*basictrigger.Outputs, error) {
return anyTrigger, nil
}

_, err = actionandtriggermock.NewBasicCapability(t)
require.NoError(t, err)

runner := testutils.NewDonRunner(t, nil)
require.NoError(t, err)

anyResult := "ok"
runner.Run(&sdk.WorkflowArgs[sdk.DonRuntime]{
Handlers: []sdk.Handler[sdk.DonRuntime]{
sdk.NewDonHandler(
basictrigger.Basic{}.Trigger(anyConfig),
func(rt sdk.DonRuntime, input *basictrigger.Outputs) (string, error) {
return anyResult, nil
},
),
sdk.NewDonHandler(
actionandtrigger.Basic{}.Trigger(anyConfig2),
func(rt sdk.DonRuntime, in *actionandtrigger.TriggerEvent) (*string, error) {
assert.Fail(t, "This trigger shouldn'tb fire")
return nil, nil
},
),
},
})

_, _, err = runner.Result()
require.NoError(t, err)
}

func TestRunner_FiringTwoTriggersReturnsAnError(t *testing.T) {
anyConfig1 := &basictrigger.Config{Name: "a", Number: 1}
anyConfig2 := &actionandtrigger.Config{Name: "b"}
Expand Down Expand Up @@ -254,6 +294,47 @@ func TestRunner_StrictTriggers_FailsIfTriggerIsNotRegistered(t *testing.T) {
assert.Error(t, err)
}

func TestRunner_StrictTriggers_FailsIfTriggerIsNotStubbed(t *testing.T) {
anyConfig := &basictrigger.Config{Name: "name", Number: 123}
anyConfig2 := &actionandtrigger.Config{Name: "b"}
anyTrigger := &basictrigger.Outputs{CoolOutput: "cool"}

trigger, err := basictriggermock.NewBasicCapability(t)
require.NoError(t, err)
trigger.Trigger = func(_ context.Context, config *basictrigger.Config) (*basictrigger.Outputs, error) {
return anyTrigger, nil
}

_, err = actionandtriggermock.NewBasicCapability(t)
require.NoError(t, err)

runner := testutils.NewDonRunner(t, nil)
require.NoError(t, err)
runner.SetStrictTriggers(true)

anyResult := "ok"
runner.Run(&sdk.WorkflowArgs[sdk.DonRuntime]{
Handlers: []sdk.Handler[sdk.DonRuntime]{
sdk.NewDonHandler(
basictrigger.Basic{}.Trigger(anyConfig),
func(rt sdk.DonRuntime, input *basictrigger.Outputs) (string, error) {
return anyResult, nil
},
),
sdk.NewDonHandler(
actionandtrigger.Basic{}.Trigger(anyConfig2),
func(rt sdk.DonRuntime, in *actionandtrigger.TriggerEvent) (*string, error) {
assert.Fail(t, "This trigger shouldn'tb fire")
return nil, nil
},
),
},
})

_, _, err = runner.Result()
assert.Error(t, err)
}

func TestRunner_CanStartInNodeMode(t *testing.T) {
anyConfig := &nodetrigger.Config{Name: "name", Number: 123}
anyTrigger := &nodetrigger.Outputs{CoolOutput: "cool"}
Expand Down
Loading