Skip to content

Add relayerset mock and extra validation to limitAndSort proto helpers#1245

Merged
ilija42 merged 2 commits intomainfrom
add-relayerset-mock
Jun 10, 2025
Merged

Add relayerset mock and extra validation to limitAndSort proto helpers#1245
ilija42 merged 2 commits intomainfrom
add-relayerset-mock

Conversation

@ilija42
Copy link
Contributor

@ilija42 ilija42 commented Jun 9, 2025

Requires

Supports

@ilija42 ilija42 requested a review from a team as a code owner June 9, 2025 20:57
@ilija42 ilija42 requested a review from patrickhuie19 June 9, 2025 20:57
@ilija42 ilija42 requested a review from jmank88 June 10, 2025 11:42
@jmank88
Copy link
Contributor

jmank88 commented Jun 10, 2025

Where is the mock used? It is usually cleaner to generate them locally. Our habit of exporting mocks is not a great one, especially with the name collisions from using just package mocks. Nbd in this case since there is local precedent already though 🤷

@ilija42 ilija42 merged commit f0d618f into main Jun 10, 2025
12 of 15 checks passed
@ilija42 ilija42 deleted the add-relayerset-mock branch June 10, 2025 12:13
@ilija42
Copy link
Contributor Author

ilija42 commented Jun 10, 2025

Where is the mock used? It is usually cleaner to generate them locally. Our habit of exporting mocks is not a great one, especially with the name collisions from using just package mocks. Nbd in this case since there is local precedent already though 🤷

Using it for mocking the relayer in capabilities, could've added a mocks package there I guess

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants