Conversation
DylanTinianov
had a problem deploying
to
integration
GitHub Actions
Error
DylanTinianov
had a problem deploying
to
integration
GitHub Actions
Error
DylanTinianov
had a problem deploying
to
integration
GitHub Actions
Error
DylanTinianov
temporarily deployed
to
integration
GitHub Actions
Inactive
DylanTinianov
had a problem deploying
to
integration
GitHub Actions
Failure
DylanTinianov
had a problem deploying
to
integration
GitHub Actions
Failure
DylanTinianov
temporarily deployed
to
integration
GitHub Actions
Inactive
DylanTinianov
had a problem deploying
to
integration
GitHub Actions
Error
DylanTinianov
had a problem deploying
to
integration
GitHub Actions
Error
…ontractkit/chainlink-common into CAPPL-903-module-time-hook
DylanTinianov
had a problem deploying
to
integration
GitHub Actions
Failure
DylanTinianov
temporarily deployed
to
integration
GitHub Actions
Inactive
DylanTinianov
temporarily deployed
to
integration
GitHub Actions
Inactive
…common into CAPPL-903-module-time-hook
DylanTinianov
temporarily deployed
to
integration
GitHub Actions
Inactive
DylanTinianov
had a problem deploying
to
integration
GitHub Actions
Failure
DylanTinianov
had a problem deploying
to
integration
GitHub Actions
Failure
nolag
reviewed
Jul 10, 2025
DylanTinianov
temporarily deployed
to
integration
GitHub Actions
Inactive
DylanTinianov
had a problem deploying
to
integration
GitHub Actions
Failure
DylanTinianov
had a problem deploying
to
integration
GitHub Actions
Failure
nolag
reviewed
Jul 10, 2025
DylanTinianov
temporarily deployed
to
integration
GitHub Actions
Inactive
DylanTinianov
had a problem deploying
to
integration
GitHub Actions
Failure
DylanTinianov
had a problem deploying
to
integration
GitHub Actions
Failure
nolag
approved these changes
Jul 10, 2025
MStreet3
reviewed
Jul 10, 2025
| case <-t.ctx.Done(): | ||
| return | ||
| } | ||
| } else { |
Contributor
There was a problem hiding this comment.
Actually, it may be a bug in the error condition. It will send the error to the channel, but not return.
Contributor
There was a problem hiding this comment.
should add a continue after sending the error, unless the fetcher should die after an error
MStreet3
reviewed
Jul 10, 2025
MStreet3
reviewed
Jul 10, 2025
Comment on lines
+10
to
+12
| // Provider wraps an existing OCR3 plugin provider (from the relayer) | ||
| // and overrides the plugin factory and contract transmitter for DonTime. | ||
| type Provider struct { |
Contributor
Author
There was a problem hiding this comment.
It's needed for initializing the plugin since we create a custom transmitter.
MStreet3
approved these changes
Jul 10, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Enabled DON Time module hooks.
Jira Ticket
Requires
WorkflowLib Plugin