[PRIV-88] Proto changes to support vault plugin#1367
Merged
cedric-cordenier merged 2 commits intomainfrom Jul 11, 2025
Merged
Conversation
cedric-cordenier
force-pushed
the
vault-plugin
branch
from
24fc164 to
8031745
Compare
cedric-cordenier
had a problem deploying
to
integration
GitHub Actions
Failure
cedric-cordenier
had a problem deploying
to
integration
GitHub Actions
Error
cedric-cordenier
had a problem deploying
to
integration
GitHub Actions
Error
cedric-cordenier
force-pushed
the
vault-plugin
branch
from
8031745 to
f57a008
Compare
cedric-cordenier
temporarily deployed
to
integration
GitHub Actions
Inactive
cedric-cordenier
had a problem deploying
to
integration
GitHub Actions
Failure
cedric-cordenier
had a problem deploying
to
integration
GitHub Actions
Failure
cedric-cordenier
changed the title
DeividasK
reviewed
Jul 11, 2025
| } | ||
|
|
||
| oneof response { | ||
| CreateSecretsResponse create_secrets_response = 8; |
Contributor
There was a problem hiding this comment.
Should we leave some empty values here in case we introduce additional request types? I.e., start with 18 or something?
Contributor
Author
There was a problem hiding this comment.
If we add more fields we can just add the numbers we need; it'll be out of order but that's not usually a problem
DeividasK
reviewed
Jul 11, 2025
DeividasK
previously approved these changes
Jul 11, 2025
cedric-cordenier
force-pushed
the
vault-plugin
branch
from
f57a008 to
df367a7
Compare
cedric-cordenier
had a problem deploying
to
integration
GitHub Actions
Failure
cedric-cordenier
temporarily deployed
to
integration
GitHub Actions
Inactive
cedric-cordenier
had a problem deploying
to
integration
GitHub Actions
Failure
DeividasK
previously approved these changes
Jul 11, 2025
cedric-cordenier
force-pushed
the
vault-plugin
branch
from
df367a7 to
a70dc96
Compare
cedric-cordenier
had a problem deploying
to
integration
GitHub Actions
Failure
cedric-cordenier
temporarily deployed
to
integration
GitHub Actions
Inactive
cedric-cordenier
had a problem deploying
to
integration
GitHub Actions
Failure
george-dorin
approved these changes
Jul 11, 2025
agparadiso
approved these changes
Jul 11, 2025
cedric-cordenier
had a problem deploying
to
integration
GitHub Actions
Failure
cedric-cordenier
temporarily deployed
to
integration
GitHub Actions
Inactive
cedric-cordenier
had a problem deploying
to
integration
GitHub Actions
Failure
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The changes are fully backwards compatible so can be merged independently from the chainlink PR.