Skip to content

beholder: add MetricCompressorEnabled flag #1536

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

beholder: add MetricCompressorEnabled flag #1536

wants to merge 2 commits into from

Conversation

pkcll
Copy link
Contributor

@pkcll pkcll commented Sep 10, 2025 •
edited
Loading

What?
Add flag to enable compression for metrics OTLP/gRPC telemetry data exported via beholder client

Why?

Mitigate error:

failed to upload metrics: rpc error: code = ResourceExhausted desc = grpc: received message larger than max (5289803 vs. 4194304)

@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 10, 2025 •
edited
Loading

apidiff results - no incompatible changes detected ✅

Module: github-com-smartcontractkit-chainlink-common

Status: ✅ 3 compatible changes

(Full summary: https://github.com/smartcontractkit/chainlink-common/actions/runs/17686827194/#summary-50273332869)

@pkcll pkcll marked this pull request as ready for review September 12, 2025 14:57
@pkcll pkcll requested review from a team as code owners September 12, 2025 14:57
kirqz23
kirqz23 approved these changes Sep 12, 2025
View reviewed changes
Copy link
Contributor

@kirqz23 kirqz23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pkcll pkcll requested review from patrickhuie19 and removed request for mchain0 September 12, 2025 21:50
@github-actions GitHub Actions
Copy link

This PR is stale because it has been open 30 days with no activity.
Remove the stale label or comment or this will be closed in 7 days.

@github-actions github-actions bot added the Stale label Oct 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kirqz23 kirqz23 kirqz23 approved these changes

@pavel-raykov pavel-raykov pavel-raykov approved these changes

@engnke engnke engnke approved these changes

@patrickhuie19 patrickhuie19 Awaiting requested review from patrickhuie19

Assignees

No one assigned

Labels

Stale

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@pkcll @kirqz23 @pavel-raykov @engnke