Skip to content

Conversation

hendoxc
Copy link
Contributor

@hendoxc hendoxc commented Oct 10, 2025

What

Wires up loops to use rotating beholder auth headers

  • INFOPLAT-2963 Adds TTL to loop config
  • INFOPLAT-2963 Wires up Keystore as Signer impl for beholder headers

Copy link

github-actions bot commented Oct 10, 2025

⚠️ API Diff Results - Breaking changes detected

📦 Module: github-com-smartcontractkit-chainlink-common

🔴 Breaking Changes (2)

pkg/beholder (1)
  • NewRotatingAuth — Type changed:
func(
  crypto/ed25519.PublicKey, 
  Signer, 
  time.Duration, 
  - bool
  + bool, 
  + map[string]string
)
Auth
pkg/beholder.Signer (1)
  • Sign — Type changed:
func(
  context.Context, 
  - []byte, 
  + string, 
  []byte
)
([]byte, error)

📄 View full apidiff report

mentions that it is thread-safe
Removes wire up

Removes code refactor
@hendoxc hendoxc force-pushed the INFOPLAT-2963-beholder-rotating-auth-headers-loop-impl branch from f43c5ce to 6781ddd Compare October 16, 2025 20:24
pkcll
pkcll previously approved these changes Oct 17, 2025
@hendoxc hendoxc requested a review from jmank88 October 17, 2025 14:04
jmank88
jmank88 previously approved these changes Oct 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants