bump chipingress#2148
Conversation
|
👋 pkcll, thanks for creating this pull request! To help reviewers, please consider creating future PRs as drafts first. This allows you to self-review and make any final changes before notifying the team. Once you're ready, you can mark it as "Ready for review" to request feedback. Thanks! |
📊 API Diff Results
|
There was a problem hiding this comment.
Pull request overview
Updates the root module’s dependency on github.com/smartcontractkit/chainlink-common/pkg/chipingress to a newer pseudo-version, ensuring consumers of the root chainlink-common module pull in the latest chip ingress changes.
Changes:
- Bump
github.com/smartcontractkit/chainlink-common/pkg/chipingressfromv0.0.11-0.20260528204832-58c7145c53f8tov0.0.11-0.20260611211700-a034c8d80da3ingo.mod. - Update corresponding
go.sumentries for the new chipingress pseudo-version.
Reviewed changes
Copilot reviewed 1 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| go.mod | Bumps the required chipingress module pseudo-version. |
| go.sum | Updates checksums to match the bumped chipingress version. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
What's Changed
This bump spans 2 commits on
pkg/chipingress:6a4c28faa050026b00request_size_bytesRange:
58c7145c53f8→a034c8d80da3· 8 files, +1085 / −158Files changed
1. Proto / API (#2085)
PublishBatchis no longer strictly atomic. New behavior:transaction_enabledunset orfalse→ valid events are produced; invalid ones return per-event errors inPublishResponse.resultstransaction_enabled = true→ any per-event failure fails the whole batchNew proto types:
PublishOptionswith optionalbool transaction_enabledPublishErrorCodeenum (validation, schema missing, encode error, domain misconfig, …)PublishErroronPublishResult(field renamedeventId→event_id)CloudEventBatch.optionsfield2. Client layer (
client.go,types.go)EventsToBatchWithOpts(events, opts...)— new;EventsToBatchdelegates to itWithTransactionEnabled(bool) BatchOpt— always emitsPublishOptionson the wirePublishOptions{TransactionEnabled: false}(explicit partial delivery)PublishOptions,PublishError,PublishErrorCode3. Batch client (
batch/client.go)WithTransactionEnabled(bool)opt (defaultfalse)PublishErrortype + error code constants (including client-sideErrCodeResultsMismatch)resp.ResultsviacompleteBatchCallbacksFromResultstransaction_enabled=true: all callbacks get the same errornewBatchRequestalways includesPublishOptionschip_ingress.batch.results_mismatch_totaltransaction_enabled4. Metrics (#2136)
chip_ingress.batch.request_size_byteshistogram gets explicit buckets:1KiB · 4KiB · 16KiB · 64KiB · 256KiB · 512KiB · 1MiB · 2MiB · 4MiB · 8MiB · 10MiB5. Tests
Large additions in
batch/client_test.goandclient_test.gocovering partial delivery callbacks, transaction modes, proto roundtrips, and result-count mismatches.