Skip to content

Added request id and new feature flag #2214

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
russell-stern wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Added request id and new feature flag #2214

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
56 changes: 48 additions & 8 deletions pkg/capabilities/actions/vault/messages.pb.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 4 additions & 0 deletions pkg/capabilities/actions/vault/messages.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,6 +67,7 @@ message CreateSecretResponse {

message CreateSecretsResponse {
repeated CreateSecretResponse responses = 1;
string request_id = 2;
}

message UpdateSecretsRequest {
Expand All @@ -84,6 +85,7 @@ message UpdateSecretResponse {

message UpdateSecretsResponse {
repeated UpdateSecretResponse responses = 1;
string request_id = 2;
}

message DeleteSecretsRequest {
Expand All @@ -101,6 +103,7 @@ message DeleteSecretResponse {

message DeleteSecretsResponse {
repeated DeleteSecretResponse responses = 1;
string request_id = 2;
}

message ListSecretIdentifiersRequest {
Expand All @@ -115,6 +118,7 @@ message ListSecretIdentifiersResponse {
repeated SecretIdentifier identifiers = 1;
bool success = 2;
string error = 3;
string request_id = 4;
}

enum RequestType {
Expand Down
1 change: 1 addition & 0 deletions pkg/settings/cresettings/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,6 +45,7 @@ flowchart
VaultGetSecretsShareAggregationIncludesPublicKeys[/VaultGetSecretsShareAggregationIncludesPublicKeys\]:::gate
VaultOwnerAddressCanonicalizationEnabled[/VaultOwnerAddressCanonicalizationEnabled\]:::gate
VaultJSONOmitUnpopulatedEnabled[/VaultJSONOmitUnpopulatedEnabled\]:::gate
VaultSignedResponseRequestIDEnabled[/VaultSignedResponseRequestIDEnabled\]:::gate
end
subgraph HandleNodeMessage[gatewayHandler.HandleNodeMessage]
Expand Down
1 change: 1 addition & 0 deletions pkg/settings/cresettings/defaults.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@
"VaultGetSecretsShareAggregationIncludesPublicKeys": "false",
"VaultOwnerAddressCanonicalizationEnabled": "false",
"VaultJSONOmitUnpopulatedEnabled": "false",
"VaultSignedResponseRequestIDEnabled": "false",
"GatewayHTTPGlobalRate": "500rps:500",
"GatewayHTTPPerNodeRate": "100rps:100",
"GatewayConfidentialRelayGlobalRate": "50rps:10",
Expand Down
1 change: 1 addition & 0 deletions pkg/settings/cresettings/defaults.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@ VaultOptimizationsEnabled = 'false'
VaultGetSecretsShareAggregationIncludesPublicKeys = 'false'
VaultOwnerAddressCanonicalizationEnabled = 'false'
VaultJSONOmitUnpopulatedEnabled = 'false'
VaultSignedResponseRequestIDEnabled = 'false'
GatewayHTTPGlobalRate = '500rps:500'
GatewayHTTPPerNodeRate = '100rps:100'
GatewayConfidentialRelayGlobalRate = '50rps:10'
Expand Down
2 changes: 2 additions & 0 deletions pkg/settings/cresettings/settings.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,6 +66,7 @@ var Default = Schema{
VaultGetSecretsShareAggregationIncludesPublicKeys: Bool(false),
VaultOwnerAddressCanonicalizationEnabled: Bool(false),
VaultJSONOmitUnpopulatedEnabled: Bool(false),
VaultSignedResponseRequestIDEnabled: Bool(false),
GatewayHTTPGlobalRate: Rate(rate.Limit(500), 500),
GatewayHTTPPerNodeRate: Rate(rate.Limit(100), 100),
GatewayConfidentialRelayGlobalRate: Rate(rate.Limit(50), 10),
Expand Down Expand Up @@ -303,6 +304,7 @@ type Schema struct {
VaultGetSecretsShareAggregationIncludesPublicKeys Setting[bool]
VaultOwnerAddressCanonicalizationEnabled Setting[bool]
VaultJSONOmitUnpopulatedEnabled Setting[bool]
VaultSignedResponseRequestIDEnabled Setting[bool]
GatewayHTTPGlobalRate Setting[config.Rate]
GatewayHTTPPerNodeRate Setting[config.Rate]
GatewayConfidentialRelayGlobalRate Setting[config.Rate]
Expand Down
1 change: 1 addition & 0 deletions pkg/settings/cresettings/settings_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -138,6 +138,7 @@ func TestSchema_Unmarshal(t *testing.T) {
assert.False(t, cfg.VaultGetSecretsShareAggregationIncludesPublicKeys.DefaultValue)
assert.False(t, cfg.VaultOwnerAddressCanonicalizationEnabled.DefaultValue)
assert.False(t, cfg.VaultJSONOmitUnpopulatedEnabled.DefaultValue)
assert.False(t, cfg.VaultSignedResponseRequestIDEnabled.DefaultValue)
assert.Equal(t, config.Rate{Limit: rate.Limit(20), Burst: 7}, cfg.GatewayConfidentialRelayGlobalRate.DefaultValue)
assert.Equal(t, config.Rate{Limit: rate.Limit(4), Burst: 2}, cfg.GatewayConfidentialRelayPerNodeRate.DefaultValue)
assert.Equal(t, 48*time.Hour, cfg.PerOrg.ZeroBalancePruningTimeout.DefaultValue)
Expand Down
Loading