Skip to content

Conversation

graham-chainlink
Copy link
Collaborator

In order to remove migration cli command, we need to support database/addressbook merge on the dp cli side since the ci uses the merge command to merge datastore and address book in the workflow

Copy link

changeset-bot bot commented Oct 16, 2025

🦋 Changeset detected

Latest commit: cce7042

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
chainlink-deployments-framework Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@graham-chainlink graham-chainlink marked this pull request as ready for review October 16, 2025 03:08
@graham-chainlink graham-chainlink requested a review from a team as a code owner October 16, 2025 03:08
@Copilot Copilot AI review requested due to automatic review settings October 16, 2025 03:08
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds address book and datastore merge/migrate commands to the durable pipeline CLI to support the removal of the migration CLI command. The CI workflow currently uses these merge commands to combine datastore and address book artifacts.

Key Changes:

  • Added two new command groups (address-book and datastore) under the durable-pipeline command
  • Implemented merge operations for both address book and datastore, plus a migrate operation for address book
  • Added comprehensive test coverage for command structure and metadata

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.

File Description
engine/cld/legacy/cli/commands/durable-pipelines.go Implements three new commands: address-book merge/migrate and datastore merge with their respective flags and RunE handlers
engine/cld/legacy/cli/commands/durable-pipelines_test.go Adds tests validating command structure, subcommand presence, and metadata (Use, Short, Long, Example, flags)
.changeset/orange-planets-sing.md Changeset file documenting this as a minor feature addition

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

In order to remove migration cli command, we need to support database/addressbook merge on the dp cli side since the ci uses the merge command to merge datastore and address book.
@cl-sonarqube-production
Copy link

Copy link
Contributor

@bytesizedroll bytesizedroll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm purposefully leaving this for the end, we need to change a bunch of workflows for this as well and I'd like to do that in one shot.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants