-
Notifications
You must be signed in to change notification settings - Fork 1
feat(cli): clone addressbook/datastore merge to dp cli #521
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
🦋 Changeset detectedLatest commit: cce7042 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds address book and datastore merge/migrate commands to the durable pipeline CLI to support the removal of the migration CLI command. The CI workflow currently uses these merge commands to combine datastore and address book artifacts.
Key Changes:
- Added two new command groups (
address-book
anddatastore
) under thedurable-pipeline
command - Implemented merge operations for both address book and datastore, plus a migrate operation for address book
- Added comprehensive test coverage for command structure and metadata
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
File | Description |
---|---|
engine/cld/legacy/cli/commands/durable-pipelines.go | Implements three new commands: address-book merge/migrate and datastore merge with their respective flags and RunE handlers |
engine/cld/legacy/cli/commands/durable-pipelines_test.go | Adds tests validating command structure, subcommand presence, and metadata (Use, Short, Long, Example, flags) |
.changeset/orange-planets-sing.md | Changeset file documenting this as a minor feature addition |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
In order to remove migration cli command, we need to support database/addressbook merge on the dp cli side since the ci uses the merge command to merge datastore and address book.
4edf24b
to
cce7042
Compare
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm purposefully leaving this for the end, we need to change a bunch of workflows for this as well and I'd like to do that in one shot.
In order to remove migration cli command, we need to support database/addressbook merge on the dp cli side since the ci uses the merge command to merge datastore and address book in the workflow