data streams noop feemanager #312
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds a no-op implementation of the FeeManager interface for data streams that returns zero fees and 100% discounts without collecting any fees or performing state changes.
- Implements NoOpFeeManager contract that refunds all ETH and charges no fees
- Adds comprehensive test coverage for the no-op fee manager functionality
- Integrates the new contract into the build and generation pipelines
Reviewed changes
Copilot reviewed 6 out of 7 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| contracts/src/v0.8/llo-feeds/v0.5.0/NoOpFeeManager.sol | Core no-op fee manager implementation with ETH refund functionality |
| contracts/src/v0.8/llo-feeds/v0.5.0/test/fee-manager/NoOpFeeManager.t.sol | Test suite validating no-op behavior and interface compatibility |
| contracts/scripts/native_solc_compile_all_llo-feeds | Adds NoOpFeeManager to the compilation script |
| gethwrappers/llo-feeds/go_generate.go | Adds Go wrapper generation for NoOpFeeManager |
| gethwrappers/llo-feeds/generation/generated-wrapper-dependency-versions-do-not-edit.txt | Registers NoOpFeeManager wrapper dependencies |
| contracts/gas-snapshots/llo-feeds.gas-snapshot | Gas usage metrics for NoOpFeeManager test cases |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
contracts/src/v0.8/llo-feeds/v0.5.0/test/fee-manager/NoOpFeeManager.t.sol
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.