Skip to content

Conversation

@finleydecker
Copy link
Contributor

Copilot AI review requested due to automatic review settings December 19, 2025 04:51
@finleydecker finleydecker requested a review from a team as a code owner December 19, 2025 04:51
@github-actions
Copy link
Contributor

👋 finleydecker, thanks for creating this pull request!

To help reviewers, please consider creating future PRs as drafts first. This allows you to self-review and make any final changes before notifying the team.

Once you're ready, you can mark it as "Ready for review" to request feedback. Thanks!

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds support for the Jovay chain type to the chainlink codebase by registering it as a new chain type and including it in the list of chains that require special log index handling.

Key changes:

  • Adds ChainJovay constant to the chain type enumeration
  • Includes Jovay in validation, parsing, and error message lists
  • Adds Jovay to chains requiring special log index handling

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File Description
pkg/config/chaintype/chaintype.go Adds ChainJovay constant and includes it in validation, parsing, and error message functions
pkg/client/rpc_client.go Adds ChainJovay to the switch cases for makeLogsValid and makeLogValid functions

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copy link
Contributor

@stackman27 stackman27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a test as well in
pkg/client/rpc_client_internal_test.go and pkg/client/rpc_client_test.go

ref: https://github.com/smartcontractkit/chainlink-evm/pull/193/changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants