Implement Token Pools #129
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
patricios-space
force-pushed
the
feat/tokenpools/ratelimiter
branch
2 times, most recently
from
252107c to
714dd93
Compare
krebernisak
reviewed
Sep 3, 2025
patricios-space
changed the title
There was a problem hiding this comment.
Pull Request Overview
This PR implements the first iteration of Token Pools functionality for the CCIP (Cross-Chain Interoperability Protocol) project, introducing a POC (Proof of Concept) implementation with corresponding E2E tests for onramp token transfers.
- Adds comprehensive Token Pool infrastructure with LockReleaseTokenPool implementation
- Implements rate limiting, allowlist management, and cross-chain configuration
- Provides TypeScript wrappers and test infrastructure for Token Pool contracts
- Creates E2E tests demonstrating token transfer functionality through the CCIP router
Reviewed Changes
Copilot reviewed 42 out of 45 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| contracts/wrappers/utils.ts | Adds Slice import and CellLoader type for enhanced cell parsing capabilities |
| contracts/wrappers/pools/ | New module with comprehensive Token Pool wrappers including LockReleaseTokenPool, TokenPools, and RateLimiter |
| contracts/wrappers/jetton/ | Adds JettonCode utilities for loading compiled jetton contracts |
| contracts/wrappers/ccip/ | Updates Router and FeeQuoter with improved message builders and token amount handling |
| contracts/tests/pools/ | Complete test suite for Token Pools including setup classes and E2E specifications |
| contracts/contracts/pools/ | Core Tolk implementation of LockReleaseTokenPool with storage, messages, and business logic |
| contracts/contracts/lib/ | Supporting libraries for token pools, rate limiting, and utility functions |
Comments suppressed due to low confidence (1)
contracts/wrappers/pools/LockReleaseTokenPool.ts:1
- Dictionary value type mismatch: should use
Dictionary.Values.Bool()instead ofDictionary.Values.Address()since the allowList is a Set where the values represent boolean membership status.
import {
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
patricios-space
force-pushed
the
feat/tokenpools/ratelimiter
branch
2 times, most recently
from
cbe5beb to
476ad42
Compare
patricios-space
force-pushed
the
feat/tokenpools/ratelimiter
branch
2 times, most recently
from
4128b06 to
d15dbb9
Compare
| fun LockReleaseTokenPool.tokenPool(self): TokenPool<LockReleaseTokenPool> { | ||
| val tokenPoolData = lazy self.data.tokenPoolData.load(); | ||
|
|
||
| return TokenPool<LockReleaseTokenPool>{ |
There was a problem hiding this comment.
Where is TokenPool<T> defined? cannot find it anywhere. Should this be IPool<LockReleaseTokenPool> instead?
Comment on lines
+61
to
+72
| /// Load the contract storage as MCMS and handle the message | ||
| var lockReleaseTokenPool = LockReleaseTokenPool.load(); | ||
|
|
||
| var tokenPool = lockReleaseTokenPool.tokenPool(); | ||
|
|
||
| if (tokenPool.onInternalMessage(in.senderAddress, in.valueCoins, in.body)) { | ||
| lockReleaseTokenPool.data.tokenPoolData = tokenPool.data.toCell(); | ||
| lockReleaseTokenPool.data.storeAsContractData(); | ||
| return; | ||
| } | ||
|
|
||
| lockReleaseTokenPool.onInternalMessage(in.senderAddress, in.valueCoins, in.body); |
There was a problem hiding this comment.
This is not aligned with the feedback we received from the TON core team, I guess I'm ok with it but we should actually align ourselves on how to handle this kind of composition.
patricios-space
changed the title
patricios-space
changed the base branch from
main
to
test/token-transfer-e2e
patricios-space
force-pushed
the
feat/tokenpools/ratelimiter
branch
from
d15dbb9 to
9e5da2d
Compare
patricios-space
force-pushed
the
test/token-transfer-e2e
branch
from
84a8f0b to
89aeb19
Compare
patricios-space
force-pushed
the
feat/tokenpools/ratelimiter
branch
from
9e5da2d to
e27bd49
Compare
patricios-space
force-pushed
the
feat/tokenpools/ratelimiter
branch
from
e27bd49 to
719e287
Compare
patricios-space
force-pushed
the
test/token-transfer-e2e
branch
from
89aeb19 to
2df4447
Compare
patricios-space
force-pushed
the
test/token-transfer-e2e
branch
4 times, most recently
from
3e2424e to
100be15
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.