Skip to content

Conversation

vicentevieytes
Copy link
Collaborator

@vicentevieytes vicentevieytes commented Oct 9, 2025

Adds events

SourceChainSelectorAdded
SourceChainConfigUpdated

DestChainSelectorAdded
DestChainConfigUpdated

@vicentevieytes vicentevieytes marked this pull request as ready for review October 10, 2025 00:21
@vicentevieytes vicentevieytes requested a review from a team as a code owner October 10, 2025 00:21
@Copilot Copilot AI review requested due to automatic review settings October 10, 2025 00:21
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds source and destination chain configuration update events to the CCIP (Cross Chain Interoperability Protocol) system. It introduces new event types for tracking when chain selectors are added and when their configurations are updated.

  • Adds new event structures for source and destination chain config updates
  • Refactors log type definitions from enums to const objects with string keys
  • Updates test code to validate the new events are properly emitted

Reviewed Changes

Copilot reviewed 14 out of 14 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
pkg/ccip/bindings/onramp/onramp.go Adds Go bindings for dest chain selector events
pkg/ccip/bindings/offramp/offramp.go Adds Go bindings for source chain selector events with typo in field name
contracts/wrappers/libraries/ocr/Logs.ts Refactors OCR log types from enum to const object structure
contracts/wrappers/examples/ccip/Logs.ts Refactors receiver log types from enum to const object structure
contracts/wrappers/ccip/OnRamp.ts Updates OnRamp wrapper with new config types and codec
contracts/wrappers/ccip/OffRamp.ts Adds source chain config deserialization function
contracts/wrappers/ccip/Logs.ts Adds new CCIP log types and topic mappings for config events
contracts/tests/ccip/OffRamp.spec.ts Updates tests to validate new source chain config events
contracts/tests/ccip/CCIPRouter.spec.ts Updates tests to validate new destination chain config events
contracts/tests/Logs.ts Adds test handlers for new config update events
contracts/contracts/ccip/onramp/events.tolk Defines new destination chain config event structures
contracts/contracts/ccip/onramp/contract.tolk Implements event emission in destination chain config updates
contracts/contracts/ccip/offramp/events.tolk Defines new source chain config event structures and fixes topic name
contracts/contracts/ccip/offramp/contract.tolk Implements event emission in source chain config updates

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

}

type SourceChainConfigUpdated struct {
SourcehainSelector uint64 `tlb:"## 64"`
Copy link

Copilot AI Oct 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Field name has a typo - 'Sourcehain' should be 'SourceChain'

Suggested change
SourcehainSelector uint64 `tlb:"## 64"`
SourceChainSelector uint64 `tlb:"## 64"`

Copilot uses AI. Check for mistakes.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a good catch

@vicentevieytes vicentevieytes changed the title add source and dest config updated events [NONEVM-2684] add source and dest config updated events Oct 10, 2025
@vicentevieytes vicentevieytes changed the title [NONEVM-2684] add source and dest config updated events add source and dest config updated events Oct 10, 2025
Copy link
Collaborator

@patricios-space patricios-space left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's looking good! I was only able to find a typo

}

type SourceChainConfigUpdated struct {
SourcehainSelector uint64 `tlb:"## 64"`
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a good catch

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants