-
Notifications
You must be signed in to change notification settings - Fork 2
add source and dest config updated events #236
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds source and destination chain configuration update events to the CCIP (Cross Chain Interoperability Protocol) system. It introduces new event types for tracking when chain selectors are added and when their configurations are updated.
- Adds new event structures for source and destination chain config updates
- Refactors log type definitions from enums to const objects with string keys
- Updates test code to validate the new events are properly emitted
Reviewed Changes
Copilot reviewed 14 out of 14 changed files in this pull request and generated 1 comment.
Show a summary per file
File | Description |
---|---|
pkg/ccip/bindings/onramp/onramp.go | Adds Go bindings for dest chain selector events |
pkg/ccip/bindings/offramp/offramp.go | Adds Go bindings for source chain selector events with typo in field name |
contracts/wrappers/libraries/ocr/Logs.ts | Refactors OCR log types from enum to const object structure |
contracts/wrappers/examples/ccip/Logs.ts | Refactors receiver log types from enum to const object structure |
contracts/wrappers/ccip/OnRamp.ts | Updates OnRamp wrapper with new config types and codec |
contracts/wrappers/ccip/OffRamp.ts | Adds source chain config deserialization function |
contracts/wrappers/ccip/Logs.ts | Adds new CCIP log types and topic mappings for config events |
contracts/tests/ccip/OffRamp.spec.ts | Updates tests to validate new source chain config events |
contracts/tests/ccip/CCIPRouter.spec.ts | Updates tests to validate new destination chain config events |
contracts/tests/Logs.ts | Adds test handlers for new config update events |
contracts/contracts/ccip/onramp/events.tolk | Defines new destination chain config event structures |
contracts/contracts/ccip/onramp/contract.tolk | Implements event emission in destination chain config updates |
contracts/contracts/ccip/offramp/events.tolk | Defines new source chain config event structures and fixes topic name |
contracts/contracts/ccip/offramp/contract.tolk | Implements event emission in source chain config updates |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
} | ||
|
||
type SourceChainConfigUpdated struct { | ||
SourcehainSelector uint64 `tlb:"## 64"` |
Copilot
AI
Oct 10, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Field name has a typo - 'Sourcehain' should be 'SourceChain'
SourcehainSelector uint64 `tlb:"## 64"` | |
SourceChainSelector uint64 `tlb:"## 64"` |
Copilot uses AI. Check for mistakes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a good catch
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's looking good! I was only able to find a typo
} | ||
|
||
type SourceChainConfigUpdated struct { | ||
SourcehainSelector uint64 `tlb:"## 64"` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a good catch
Adds events