Add manual execution to offramp #249
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
archseer
commented
Oct 16, 2025
| struct (0xa00785cf) OffRamp_ManuallyExecute { | ||
| queryId: uint64; | ||
| report: ExecutionReport; | ||
| gasOverride: coins; // TODO: should this just be part of the added gas value passed into the call? |
There was a problem hiding this comment.
I think we can just pass through all TON value specified on the call here and avoid this override
There was a problem hiding this comment.
Agree, but then we have to change the logic where we check msg.gasOverride != null and instead add a specific handler for manual exec in the MerkleRoot
archseer
commented
Oct 16, 2025
| message: msg.message, | ||
| }); | ||
| } | ||
| SetRejectAll => { |
There was a problem hiding this comment.
@nicolasgnr like Solana the new receiver supports toggling a receiver to deliberately fail. I didn't add any access control checks since this shouldn't be used outside of testnet?
archseer
commented
Oct 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.