Execute report gobinding #51

huangzhen1997 · 2025-06-16T21:40:42Z

Gobinding for encoding/decoding execute report, following format from contract skeleton PR.

krebernisak · 2025-07-10T10:30:14Z

pkg/ccip/bindings/types.go

+		if err != nil {
+			return nil, fmt.Errorf("failed to unpack inner array: %w", err)
+		}
+		if len(data) != int(length) {


Why do we store the length here, just to check for mismatch? This seems unnecessary

We need to know where to stop reading for each array, and it's indicated by the length we stored before reading each array, when parsing the linked cell.

I might be missing something, can you point me to the LOC where length is used to stop reading the current item?

You are right the length is not used, I'm revisiting the implementation now. This is used for the offchainData for ccip types and in offramp contract,

There's a bug, I will fix it

krebernisak · 2025-07-10T10:39:09Z

pkg/ccip/bindings/executereport.go

+	Messages            SnakeRef[Any2TONRampMessage] `tlb:"^"`
+	OffChainTokenData   SnakeBytes2D                 `tlb:"^"`
+	Proofs              SnakeData[Signature]         `tlb:"^"` // []Signature


I kinda suspect we don't actually need three different ways to encode collections of data, do we? cc @archseer

SnakeData stores array objects in a linked-cell format using the cell's data slice. It only supports structs that do not contain cell references, as it cannot be automatically serialized via TLB otherwise.

SnakeRef addresses this limitation by storing array objects in reference cells instead of the data slice, allowing support for structs that include cell references.

These three are different encoding schemes, but they provide optimal storage efficiency for complex data types.

I was able to solve SnakeData and SnakeRef onchain when decoding in a single pass, but it was dependent on the typed Cell<T> wrapper (Iterator parses directly, Iterator<Cell> loads a ref then parses it), but I'm not sure if there's a straightforward way to do that in Go.

I think we could at least reuse SnakeRef for SnakeBytes2D: it's essentially SnakeRef[SnakeData[[]byte]]`?

I wasn't sure how the on-chain [][]byte was encoded, from previous conversation I thought we were going to SnakeBytes2D including array length. We can use SnakeRef[SnakeBytes], to make it simpler, it's just we will need to use more cell, as it produce fragmentation in the cell data.

Just pushed a change

pkg/ccip/bindings/types.go

Copilot

Pull Request Overview

Implements Gobinding for CCIP ExecuteReport messages with new packing/unpacking utilities and tests, and updates dependencies.

Introduce generic TLB packing/unpacking helpers (packArrayWithStaticType, SnakeData, etc.) and comprehensive unit tests in types.go/types_test.go.
Add ExecuteReport binding and corresponding encoding/decoding tests in executereport.go/executereport_test.go.
Remove old commit report implementation but left tests referencing CommitReport, causing a mismatch; update module dependencies and Nix vendor hash.

Reviewed Changes

Copilot reviewed 8 out of 9 changed files in this pull request and generated 3 comments.

Show a summary per file

File	Description
pkg/ccip/bindings/types.go	Add array/cell packing and unpacking functions (`packArrayWithStaticType`, `pack2D...`).
pkg/ccip/bindings/types_test.go	Add unit tests covering edge cases for all new TLB utilities.
pkg/ccip/bindings/executereport.go	Define `ExecuteReport` and related TLB-annotated types.
pkg/ccip/bindings/executereport_test.go	Add tests to validate encoding and decoding of `ExecuteReport`.
pkg/ccip/bindings/commitreport.go	Removed commit report logic but tests still reference `CommitReport` (incomplete update).
pkg/ccip/bindings/commitreport_test.go	Old tests pruned, but `TestCommitReport_EncodingAndDecoding` remains without implementation
go.mod	Add Solana and Testify dependencies and bump versions.
cmd/chainlink-ton/default.nix	Update `vendorHash` after dependency changes.

Comments suppressed due to low confidence (1)

pkg/ccip/bindings/commitreport.go:3

The CommitReport struct and TLB imports (fmt, github.com/xssnick/tonutils-go/tlb, tvm/cell) were removed, but tests still reference CommitReport. Reintroduce the struct definition and necessary imports to restore compilation.

import (

pkg/ccip/bindings/executereport_test.go

archseer · 2025-07-11T07:00:54Z

pkg/ccip/bindings/types.go

+
+// Signature represents an ED25519 signature.
+type Signature struct {
+	Sig []byte `tlb:"bits 512"`


Note: this now has a third field labeled pubkey that's the signer's public key

Can you point me to this new label ? I don't see it from the latest offramp contract on execute report nor commit report.

archseer · 2025-07-16T08:19:09Z

pkg/ccip/bindings/types.go

 // Signature represents an ED25519 signature.
 type Signature struct {
-	Sig []byte `tlb:"bits 512"`
+	Sig []byte `tlb:"bits 256"`


This is wrong, the signature should be 512 bits (64 bytes), plus the public key (32 bytes)

I got confused when I review the contract code, you used vec

archseer · 2025-07-16T08:20:50Z

pkg/ccip/bindings/executereport.go

+// Any2TONRampMessage represents ramp message, which is part of the execute report.
+type Any2TONRampMessage struct {
+	Header       RampMessageHeader              `tlb:"."`
+	Sender       SnakeBytes                     `tlb:"^"`


I added a new type for this called CrossChainAddress, it's 1 byte length len, followed by len bytes (one cell, no snake data, max length of 64 bytes)

It can either be in place or as ^ ref

I don't see it in the main branch, is it not merged ?

huangzhen1997 · 2025-07-16T19:35:03Z

Close this as changes are migrated to another PR #68

add execute report binding definition, pending tests

f4ef5b0

huangzhen1997 changed the title ~~add execute report binding definition, pending tests~~ Execute reporting gobinding Jun 16, 2025

huangzhen1997 added 2 commits June 17, 2025 15:33

add test coverage

caef997

update nix hash

f572af6

huangzhen1997 marked this pull request as ready for review June 17, 2025 20:57

Copilot AI review requested due to automatic review settings June 17, 2025 20:57

This comment was marked as outdated.

Sign in to view

add comments

7de2554

huangzhen1997 requested a review from Copilot June 17, 2025 21:05

This comment was marked as outdated.

Sign in to view

fix test

00bc038

huangzhen1997 requested a review from Copilot June 17, 2025 21:10

This comment was marked as outdated.

Sign in to view

huangzhen1997 requested a review from Copilot June 17, 2025 22:42

This comment was marked as outdated.

Sign in to view

huangzhen1997 changed the title ~~Execute reporting gobinding~~ Execute report gobinding Jun 18, 2025

huangzhen1997 added 5 commits June 18, 2025 15:06

update

c26aee0

add helper functions for 2d array

cd3717b

add support for unpack and packing single array bytes

fe11b85

change order

8899fb9

refactor

09428a9

huangzhen1997 mentioned this pull request Jun 23, 2025

TON execute report codec smartcontractkit/chainlink#18301

Closed

huangzhen1997 added 8 commits June 25, 2025 14:55

add proofFlagBits

7ba11a8

use dict cell for token amount

8484dd8

update comment

38db252

use cell reference chaining

99097d4

make message array

8ca4746

support extra args

49c1dca

add export function

9619763

update gas limit

fbaa006

huangzhen1997 added 6 commits July 7, 2025 14:24

Merge branch 'main' into jh/execute-report-gobinding

50dc550

mod tidy

ca6738c

update hash

9c4f84f

add all wrappers

9b3d024

refactor

09e902b

refactor

1c40381

huangzhen1997 mentioned this pull request Jul 8, 2025

Commit report gobinding support #40

Merged

merge and refactor

a2009ae

krebernisak reviewed Jul 10, 2025

View reviewed changes

pkg/ccip/bindings/types.go Outdated Show resolved Hide resolved

pkg/ccip/bindings/types.go Show resolved Hide resolved

pkg/ccip/bindings/types.go Outdated Show resolved Hide resolved

huangzhen1997 added 2 commits July 10, 2025 10:50

address comments

dd02cf4

fix bug, independent 2d array packing

2eb376f

huangzhen1997 requested review from Copilot and krebernisak July 10, 2025 18:46

This comment was marked as outdated.

Sign in to view

rename and minor

c12296c

huangzhen1997 requested a review from Copilot July 10, 2025 20:52

Copilot AI reviewed Jul 10, 2025

View reviewed changes

pkg/ccip/bindings/executereport_test.go Outdated Show resolved Hide resolved

pkg/ccip/bindings/executereport_test.go Outdated Show resolved Hide resolved

pkg/ccip/bindings/executereport_test.go Outdated Show resolved Hide resolved

clean up

d7d1af0

archseer reviewed Jul 11, 2025

View reviewed changes

huangzhen1997 added 2 commits July 11, 2025 15:56

use snakeref of snakebytes instead of snakebyte2d

7440292

reduce sig byte length

a655e91

huangzhen1997 requested a review from archseer July 14, 2025 14:11

huangzhen1997 added 2 commits July 15, 2025 11:41

fix lint

5a27d42

Merge branch 'main' into jh/execute-report-gobinding

d408376

archseer reviewed Jul 16, 2025

View reviewed changes

huangzhen1997 closed this Jul 16, 2025

huangzhen1997 deleted the jh/execute-report-gobinding branch August 11, 2025 22:25

Execute report gobinding #51

Execute report gobinding #51

Uh oh!

Conversation

huangzhen1997 commented Jun 16, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

This comment was marked as outdated.

Uh oh!

This comment was marked as outdated.

Uh oh!

This comment was marked as outdated.

Uh oh!

This comment was marked as outdated.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

huangzhen1997 Jul 10, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

krebernisak Jul 10, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

This comment was marked as outdated.

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

huangzhen1997 Jul 11, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

huangzhen1997 commented Jul 16, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

huangzhen1997 commented Jun 16, 2025 •

edited

Loading

huangzhen1997 Jul 10, 2025 •

edited

Loading

krebernisak Jul 10, 2025 •

edited

Loading

huangzhen1997 Jul 11, 2025 •

edited

Loading