Implement ability to use fixed energy value for txs #16
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HelloKashif
had a problem deploying
to
integration
GitHub Actions
Failure
HelloKashif
had a problem deploying
to
integration
GitHub Actions
Failure
KodeyThomas
reviewed
Jun 25, 2025
relayer/txm/txm.go
Outdated
| func (t *TronTxm) estimateEnergy(tx *TronTx) (int64, error) { | ||
|
|
||
| if t.EstimateEnergyEnabled { | ||
| if t.Config.EstimateEnergy { |
There was a problem hiding this comment.
this materially changes the estimateEnergy loop. previously t.EstimateEnergyEnabled is set by if the rpc node supports energy estimation, otherwise we fallback
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://chainlink-core.slack.com/archives/C07NRT2P9PG/p1750687199028919
Context: CCIP needs to send fixed gas values instead of estimation but currently it's hardcoded. We will introduce a new EstimateEnergy and EnergyAmount fields and then pass these from core. If EstimateEnergy is false and EnergyAmount specified then the txs will use that fixed amount. If the EnergyAmount is not specified then we fallback to the legacy logic
This would be a backwards incompatible change if we use the core's toml config when initalizing this object since EstimateLimit is set to false by default there. To prevent breaking any nodes we can first go ahead and enable
EstimateLimit=trueon the DF config (which are the only user atm) and then come back and merge this PR.