-
Notifications
You must be signed in to change notification settings - Fork 1.9k
Aptos (combined branch) #13716
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Aptos (combined branch) #13716
Conversation
plugin := env.NewPlugin("aptos") | ||
loopKs := &keystore.AptosLooppSigner{Aptos: ks} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perhaps all this can be moved into InitAptos?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like having this merged as an example trigger. I only wish it could go to common but it can't because of EVM dep :( Maybe we should create a special sub-directory with example capabilities and move on-demand trigger there as well...? @cedric-cordenier thoughts?
97831c9
to
7bf04f5
Compare
I see you added a changeset file but it does not contain a tag. Please edit the text include at least one of the following tags:
|
7bf04f5
to
1a0d8bb
Compare
I see you updated files related to
|
f2cb06b
to
fb21d3e
Compare
This PR is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 7 days. |
This PR is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 7 days. |
Contains #14076, #14078 and staged changes