Skip to content

Conversation

archseer
Copy link
Contributor

@archseer archseer commented Jun 28, 2024

Contains #14076, #14078 and staged changes

Comment on lines 313 to 314
plugin := env.NewPlugin("aptos")
loopKs := &keystore.AptosLooppSigner{Aptos: ks}
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps all this can be moved into InitAptos?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like having this merged as an example trigger. I only wish it could go to common but it can't because of EVM dep :( Maybe we should create a special sub-directory with example capabilities and move on-demand trigger there as well...? @cedric-cordenier thoughts?

@krebernisak krebernisak force-pushed the aptos-init branch 2 times, most recently from 97831c9 to 7bf04f5 Compare November 22, 2024 15:31
Copy link
Contributor

I see you added a changeset file but it does not contain a tag. Please edit the text include at least one of the following tags:

  • #added For any new functionality added.
  • #breaking_change For any functionality that requires manual action for the node to boot.
  • #bugfix For bug fixes.
  • #changed For any change to the existing functionality.
  • #db_update For any feature that introduces updates to database schema.
  • #deprecation_notice For any upcoming deprecation functionality.
  • #internal For changesets that need to be excluded from the final changelog.
  • #nops For any feature that is NOP facing and needs to be in the official Release Notes for the release.
  • #removed For any functionality/config that is removed.
  • #updated For any functionality that is updated.
  • #wip For any change that is not ready yet and external communication about it should be held off till it is feature complete.

🎖️ No JIRA issue number found in: PR title, commit message, or branch name. Please include the issue ID in one of these.

Copy link
Contributor

github-actions bot commented Dec 4, 2024

I see you updated files related to core. Please run pnpm changeset in the root directory to add a changeset as well as in the text include at least one of the following tags:

  • #added For any new functionality added.
  • #breaking_change For any functionality that requires manual action for the node to boot.
  • #bugfix For bug fixes.
  • #changed For any change to the existing functionality.
  • #db_update For any feature that introduces updates to database schema.
  • #deprecation_notice For any upcoming deprecation functionality.
  • #internal For changesets that need to be excluded from the final changelog.
  • #nops For any feature that is NOP facing and needs to be in the official Release Notes for the release.
  • #removed For any functionality/config that is removed.
  • #updated For any functionality that is updated.
  • #wip For any change that is not ready yet and external communication about it should be held off till it is feature complete.

🎖️ No JIRA issue number found in: PR title, commit message, or branch name. Please include the issue ID in one of these.

@krebernisak krebernisak changed the base branch from develop to aptos-init-base December 5, 2024 15:56
@krebernisak krebernisak changed the base branch from aptos-init-base to develop December 6, 2024 19:05
@krebernisak krebernisak changed the base branch from develop to release/2.19.0-aptos December 6, 2024 19:06
@krebernisak krebernisak changed the base branch from release/2.19.0-aptos to aptos-init-base December 11, 2024 11:20
@krebernisak krebernisak changed the base branch from aptos-init-base to release/2.19.0-aptos December 11, 2024 11:21
@krebernisak krebernisak changed the base branch from release/2.19.0-aptos to develop December 11, 2024 11:23
@krebernisak krebernisak changed the base branch from develop to release/2.19.0-aptos December 11, 2024 11:23
Copy link
Contributor

This PR is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 7 days.

@github-actions github-actions bot added the Stale label Feb 10, 2025
@github-actions github-actions bot closed this Feb 17, 2025
@github-actions github-actions bot deleted the aptos-init branch February 17, 2025 00:17
@cfal cfal restored the aptos-init branch February 17, 2025 12:46
@archseer archseer reopened this Feb 17, 2025
@github-actions github-actions bot removed the Stale label Feb 20, 2025
Copy link
Contributor

This PR is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 7 days.

@github-actions github-actions bot added the Stale label Apr 26, 2025
@github-actions github-actions bot closed this May 3, 2025
@github-actions github-actions bot deleted the aptos-init branch May 3, 2025 00:17
@dhaidashenko dhaidashenko restored the aptos-init branch May 6, 2025 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants