Remove legacy Mercury plugin and associated code #16014

samsondav · 2025-01-21T17:38:55Z

To be merged after plugin has been replaced by LLO.

Blocked on:

Keystone (need to migrate DF2.0 to LLO and remove legacy scripts, etc)
Data Streams (need to fully sunset all legacy feeds)

Also to be updated after this is merged:

chainlink-common (remove old legacy mercury loops plugin and related stuff)
Remove legacy v3 mercury plugin chainlink-common#1068
chainlink-data-streams (remove mercury directory)
Remove legacy Mercury plugin and associated code chainlink-data-streams#127

github-actions · 2025-01-23T17:11:32Z

AER Report: CI Core

aer_workflow , commit , Clean Go Tidy & Generate , Detect Changes , Scheduled Run Frequency , Core Tests (go_core_tests) , Core Tests (go_core_tests_integration) , Core Tests (go_core_fuzz) , GolangCI Lint (.) , Core Tests (go_core_race_tests) , test-scripts , Core Tests (go_core_ccip_deployment_tests) , lint , SonarQube Scan

1. Missing required module:

[test-scripts] Run Tests

Source of Error:

../services/relay/evm/llo_provider.go:12:2: no required module provides package github.com/smartcontractkit/chainlink/v2/core/chains/evm/logpoller; to add it:
	go get github.com/smartcontractkit/chainlink/v2/core/chains/evm/logpoller

Why: The error indicates that the package github.com/smartcontractkit/chainlink/v2/core/chains/evm/logpoller is not available in the module dependencies. This is likely because it has not been added to the go.mod file.

Suggested fix: Run go get github.com/smartcontractkit/chainlink/v2/core/chains/evm/logpoller to add the missing module to the dependencies.

[Core Tests (go_core_tests_integration)] Run tests

Source of Error:

core/services/relay/evm/llo_provider.go:12:2: no required module provides package github.com/smartcontractkit/chainlink/v2/core/chains/evm/logpoller; to add it:
	go get github.com/smartcontractkit/chainlink/v2/core/chains/evm/logpoller

Why: The error indicates that the package github.com/smartcontractkit/chainlink/v2/core/chains/evm/logpoller is not available in the module dependencies. This is likely because it has not been added to the go.mod file.

Suggested fix: Run go get github.com/smartcontractkit/chainlink/v2/core/chains/evm/logpoller to add the missing module to the dependencies.

[Core Tests (go_core_ccip_deployment_tests)] Run tests

Source of Error:

../core/services/relay/evm/llo_provider.go:12:2: no required module provides package github.com/smartcontractkit/chainlink/v2/core/chains/evm/logpoller; to add it:
	go get github.com/smartcontractkit/chainlink/v2/core/chains/evm/logpoller

Why: The error indicates that the package github.com/smartcontractkit/chainlink/v2/core/chains/evm/logpoller is not available in the module dependencies. This is likely because it has not been added to the go.mod file.

Suggested fix: Run go get github.com/smartcontractkit/chainlink/v2/core/chains/evm/logpoller to add the missing module to the dependencies.

[Core Tests (go_core_fuzz)] Run tests

Source of Error:

core/services/relay/evm/llo_provider.go:12:2: no required module provides package github.com/smartcontractkit/chainlink/v2/core/chains/evm/logpoller; to add it:
	go get github.com/smartcontractkit/chainlink/v2/core/chains/evm/logpoller

Why: The error indicates that the package github.com/smartcontractkit/chainlink/v2/core/chains/evm/logpoller is not available in the module dependencies. This is likely because it has not been added to the go.mod file.

Suggested fix: Run go get github.com/smartcontractkit/chainlink/v2/core/chains/evm/logpoller to add the missing module to the dependencies.

[Core Tests (go_core_tests)] Run tests

Source of Error:

core/services/relay/evm/llo_provider.go:12:2: no required module provides package github.com/smartcontractkit/chainlink/v2/core/chains/evm/logpoller; to add it:
	go get github.com/smartcontractkit/chainlink/v2/core/chains/evm/logpoller

Why: The error indicates that the package github.com/smartcontractkit/chainlink/v2/core/chains/evm/logpoller is not available in the module dependencies. This is likely because it has not been added to the go.mod file.

Suggested fix: Run go get github.com/smartcontractkit/chainlink/v2/core/chains/evm/logpoller to add the missing module to the dependencies.

2. Undefined fields or methods:

[GolangCI Lint (.)] Golang Lint (.)

Source of Error:

core/internal/cltest/cltest.go:264:38: app.KeyStore undefined (type *TestApplication has no field or method KeyStore) (typecheck)
	k, _ := MustInsertRandomKey(t, app.KeyStore.Eth(), chainID)
	 ^
core/internal/cltest/cltest.go:267:34: app.KeyStore undefined (type *TestApplication has no field or method KeyStore) (typecheck)
	id, ks := chainID.ToInt(), app.KeyStore.Eth()
	 ^
core/internal/cltest/cltest.go:286:27: app.GetKeyStore undefined (type *TestApplication has no field or method GetKeyStore) (typecheck)
	require.NoError(t, app.GetKeyStore().P2P().Add(ctx, v))
	 ^
core/internal/cltest/cltest.go:288:27: app.GetKeyStore undefined (type *TestApplication has no field or method GetKeyStore) (typecheck)
	require.NoError(t, app.GetKeyStore().CSA().Add(ctx, v))
	 ^
core/internal/cltest/cltest.go:290:27: app.GetKeyStore undefined (type *TestApplication has no field or method GetKeyStore) (typecheck)
	require.NoError(t, app.GetKeyStore().OCR2().Add(ctx, v))
	 ^
core/internal/cltest/cltest.go:652:12: ta.GetDB undefined (type *TestApplication has no field or method GetDB) (typecheck)
	err := ta.GetDB().GetContext(ctx, &id, `INSERT INTO sessions (id, email, last_used, created_at) VALUES ($1, $2, $3, NOW()) RETURNING id`, session.ID, email, session.LastUsed)
	 ^
core/internal/cltest/cltest.go:659:27: ta.KeyStore undefined (type *TestApplication has no field or method KeyStore) (typecheck)
	require.NoError(ta.t, ta.KeyStore.Unlock(ctx, Password))
	 ^
core/internal/cltest/cltest.go:660:15: ta.KeyStore undefined (type *TestApplication has no field or method KeyStore) (typecheck)
	_, err := ta.KeyStore.Eth().Import(ctx, []byte(content), Password, &FixtureChainID)
	 ^
core/internal/cltest/cltest.go:688:11: ta.BasicAdminUsersORM undefined (type *TestApplication has no field or method BasicAdminUsersORM) (typecheck)
	err = ta.BasicAdminUsersORM().CreateUser(ctx, &u)
	 ^
core/internal/cltest/cltest.go:710:38: ta.GetConfig undefined (type *TestApplication has no field or method GetConfig) (typecheck)
	Config: ta.GetConfig(),
	 ^
core/internal/cltest/cltest.go:729:38: ta.GetConfig undefined (type *TestApplication has no field or method GetConfig) (typecheck)
	Config: ta.GetConfig(),
	 ^
core/internal/cltest/cltest.go:1321:95: app.GetConfig undefined (type *TestApplication has no field or method GetConfig) (typecheck)
	ethClient.On("ConfiguredChainID", mock.Anything).Return(evmtest.MustGetDefaultChainID(t, app.GetConfig().EVMConfigs()), nil)
	 ^
core/capabilities/integration_tests/framework/don.go:292:18: node.Stop undefined (type *capabilityNode has no field or method Stop) (typecheck)
	if err := node.Stop(); err != nil {
	 ^
core/capabilities/integration_tests/framework/don.go:369:15: node.AddJobV2 undefined (type *capabilityNode has no field or method AddJobV2) (typecheck)
	err := node.AddJobV2(ctx, j)
	 ^
core/cmd/admin_commands.go:147:12: p.Role undefined (type *AdminUsersPresenter has no field or method Role) (typecheck)
	string(p.Role),
	 ^
core/cmd/admin_commands.go:148:5: p.HasActiveApiToken undefined (type *AdminUsersPresenter has no field or method HasActiveApiToken) (typecheck)
	p.HasActiveApiToken,
	 ^
core/cmd/admin_commands.go:149:5: p.CreatedAt undefined (type *AdminUsersPresenter has no field or method CreatedAt) (typecheck)
	p.CreatedAt.String(),
	 ^
core/cmd/admin_commands.go:150:5: p.UpdatedAt undefined (type *AdminUsersPresenter has no field or method UpdatedAt) (typecheck)
	p.UpdatedAt.String(),
	 ^
core/cmd/admin_commands.go:219:29: user.Email undefined (type AdminUsersPresenter has no field or method Email) (typecheck)
	if strings.EqualFold(user.Email, c.String("email")) {
	 ^
core/cmd/admin_commands.go:220:75: user.Email undefined (type AdminUsersPresenter has no field or method Email) (typecheck)
	return s.errorOut(fmt.Errorf("user with email %s already exists", user.Email))
	 ^
core/cmd/aptos_keys_commands.go:30:5: p.PubKey undefined (type *AptosKeyPresenter has no field or method PubKey) (typecheck)
	p.PubKey,
	 ^
core/cmd/blocks_commands.go:100:20: p.EVMChainID undefined (type *LCAPresenter has no field or method EVMChainID) (typecheck)
	return []string{p.EVMChainID.String(), p.Hash, strconv.FormatInt(p.BlockNumber, 10)}
	 ^
core/cmd/bridge_commands.go:50:37: p.Confirmations undefined (type *BridgePresenter has no field or method Confirmations) (typecheck)
	return strconv.FormatUint(uint64(p.Confirmations), 10)
	 ^
core/cmd/bridge_commands.go:57:5: p.Name undefined (type *BridgePresenter has no field or method Name) (typecheck)
	p.Name,
	 ^
core/cmd/bridge_commands.go:58:5: p.URL undefined (type *BridgePresenter has no field or method URL) (typecheck)
	p.URL,
	 ^
core/cmd/bridge_commands.go:60:5: p.OutgoingToken undefined (type *BridgePresenter has no field or method OutgoingToken) (typecheck)
	p.OutgoingToken,
	 ^
core/cmd/bridge_commands.go:73:6: p.Name undefined (type BridgePresenter has no field or method Name) (typecheck)
	p.Name,
	 ^
core/cmd/bridge_commands.go:74:6: p.URL undefined (type BridgePresenter has no field or method URL) (typecheck)
	p.URL,
	 ^
core/cmd/chains_commands.go:70:20: p.GetID undefined (type *ChainPresenter has no field or method GetID) (typecheck)
	return []string{p.GetID(), strconv.FormatBool(p.Enabled), p.Config}
	 ^
core/cmd/cosmos_keys_commands.go:30:5: p.PubKey undefined (type *CosmosKeyPresenter has no field or method PubKey) (typecheck)
	p.PubKey,
	 ^
core/cmd/cosmos_transaction_commands.go:50:7: p.TxHash undefined (type *CosmosMsgPresenter has no field or method TxHash) (typecheck)
	if p.TxHash != nil {
	 ^
core/cmd/cosmos_transaction_commands.go:51:13: p.TxHash undefined (type *CosmosMsgPresenter has no field or method TxHash) (typecheck)
	hash = *p.TxHash
	 ^
core/cmd/cosmos_transaction_commands.go:54:5: p.ChainID undefined (type *CosmosMsgPresenter has no field or method ChainID) (typecheck)
	p.ChainID,
	 ^
core/cmd/cosmos_transaction_commands.go:55:5: p.ContractID undefined (type *CosmosMsgPresenter has no field or method ContractID) (typecheck)
	p.ContractID,
	 ^
core/cmd/cosmos_transaction_commands.go:56:5: p.State undefined (type *CosmosMsgPresenter has no field or method State) (typecheck)
	p.State,
	 ^
core/cmd/csa_keys_commands.go:85:5: p.PubKey undefined (type *CSAKeyPresenter has no field or method PubKey) (typecheck)
	p.PubKey,
	 ^
core/cmd/eth_keys_commands.go:128:7: p.EthBalance undefined (type *EthKeyPresenter has no field or method EthBalance) (typecheck)
	if p.EthBalance != nil {
	 ^
core/cmd/eth_keys_commands.go:129:11: p.EthBalance undefined (type *EthKeyPresenter has no field or method EthBalance) (typecheck)
	eth = p.EthBalance.String()
	 ^
core/cmd/eth_keys_commands.go:132:7: p.LinkBalance undefined (type *EthKeyPresenter has no field or method LinkBalance) (typecheck)
	if p.LinkBalance != nil {
	 ^
core/cmd/eth_keys_commands.go:133:12: p.LinkBalance undefined (type *EthKeyPresenter has no field or method LinkBalance) (typecheck)
	link = p.LinkBalance.String()
	 ^
core/cmd/eth_keys_commands.go:136:7: p.MaxGasPriceWei undefined (type *EthKeyPresenter has no field or method MaxGasPriceWei) (typecheck)
	if p.MaxGasPriceWei != nil {
	 ^
core/cmd/eth_keys_commands.go:137:11: p.MaxGasPriceWei undefined (type *EthKeyPresenter has no field or method MaxGasPriceWei) (typecheck)
	gas = p.MaxGasPriceWei.String()
	 ^
core/cmd/eth_keys_commands.go:140:5: p.Address undefined (type *EthKeyPresenter has no field or method Address) (typecheck)
	p.Address,
	 ^
core/cmd/eth_keys_commands.go:141:5: p.EVMChainID undefined (type *EthKeyPresenter has no field or method EVMChainID) (typecheck)
	p.EVMChainID.String(),
	 ^
core/cmd/eth_keys_commands.go:144:23: p.Disabled undefined (type *EthKeyPresenter has no field or method Disabled) (typecheck)
	fmt.Sprintf("%v", p.Disabled),
	 ^
core/cmd/eth_keys_commands.go:145:5: p.CreatedAt undefined (type *EthKeyPresenter has no field or method CreatedAt) (typecheck)
	p.CreatedAt.String(),
	 ^
core/cmd/eth_keys_commands.go:146:5: p.UpdatedAt undefined (type *EthKeyPresenter has no field or method UpdatedAt) (typecheck)
	p.UpdatedAt.String(),
	 ^
core/cmd/evm_transaction_commands.go:78:5: p.From undefined (type *EthTxPresenter has no field or method From) (typecheck)
	p.From.Hex(),
	 ^
core/cmd/evm_transaction_commands.go:79:5: p.Nonce undefined (type *EthTxPresenter has no field or method Nonce) (typecheck)
	p.Nonce,
	 ^
core/cmd/evm_transaction_commands.go:80:5: p.To undefined (type *EthTxPresenter has no field or method To) (typecheck)
	p.To.Hex(),
	 ^

Why: The errors indicate that certain fields or methods are being referenced in the code but do not exist in the respective structs or interfaces. This could be due to recent changes in the codebase where these fields or methods were removed or renamed.

Suggested fix: Review the recent changes in the codebase to identify if these fields or methods were removed or renamed. Update the code to use the correct fields or methods or add the missing fields or methods if they were unintentionally removed.

AER Report: Operator UI CI ran successfully ✅

aer_workflow , commit

github-actions · 2025-02-11T16:02:21Z

Flakeguard Summary

Ran new or updated tests between develop and abad08c0df14297f2a319ccd5df5ee25f74cdc6d (MERC-6785).

View Flaky Detector Details | Compare Changes

Found Flaky Tests ❌

20 Results

Name	Pass Ratio	Panicked?	Timed Out?	Race?	Runs	Failures	Package	Package Panicked?	Avg Duration	Code Owners
TestORM_CreateJob_KeyLocking	0%	false	false	false	3	3	github.com/smartcontractkit/chainlink/v2/core/services/job	false	20ms	@smartcontractkit/foundations, @smartcontractkit/core
TestORM_CreateJob_KeyLocking/keys_locked	0%	false	false	false	3	3	github.com/smartcontractkit/chainlink/v2/core/services/job	false	0s	@smartcontractkit/foundations, @smartcontractkit/core
TestORM_CreateJob_KeyLocking/keys_not_locked	0%	false	false	false	3	3	github.com/smartcontractkit/chainlink/v2/core/services/job	false	0s	@smartcontractkit/foundations, @smartcontractkit/core
TestORM_CreateJob_OCR2_DuplicatedContractAddress	0%	false	false	false	3	3	github.com/smartcontractkit/chainlink/v2/core/services/job	false	10ms	@smartcontractkit/foundations, @smartcontractkit/core
TestORM_CreateJob_OCR2_With_DualTransmission	0%	false	false	false	3	3	github.com/smartcontractkit/chainlink/v2/core/services/job	false	33.333333ms	@smartcontractkit/foundations, @smartcontractkit/core
TestRunner	0%	false	false	false	3	3	github.com/smartcontractkit/chainlink/v2/core/services/job	false	150ms	@smartcontractkit/foundations, @smartcontractkit/core
TestRunner/deleting_jobs	0%	false	false	false	3	3	github.com/smartcontractkit/chainlink/v2/core/services/job	false	0s	@smartcontractkit/foundations, @smartcontractkit/core
TestRunner/handles_the_case_where_the_jsonparse_lookup_path_is_missing_from_the_http_response	0%	false	false	false	3	3	github.com/smartcontractkit/chainlink/v2/core/services/job	false	0s	@smartcontractkit/foundations, @smartcontractkit/core
TestRunner/handles_the_case_where_the_jsonparse_lookup_path_is_missing_from_the_http_response_and_lax_is_enabled	0%	false	false	false	3	3	github.com/smartcontractkit/chainlink/v2/core/services/job	false	0s	@smartcontractkit/foundations, @smartcontractkit/core
TestRunner/handles_the_case_where_the_parsed_value_is_literally_null	0%	false	false	false	3	3	github.com/smartcontractkit/chainlink/v2/core/services/job	false	0s	@smartcontractkit/foundations, @smartcontractkit/core
TestRunner/minimal_bootstrap	0%	false	false	false	3	3	github.com/smartcontractkit/chainlink/v2/core/services/job	false	0s	@smartcontractkit/foundations, @smartcontractkit/core
TestRunner/referencing_a_non-existent_bridge_should_error	0%	false	false	false	3	3	github.com/smartcontractkit/chainlink/v2/core/services/job	false	10ms	@smartcontractkit/foundations, @smartcontractkit/core
TestRunner/test_enhanced_telemetry_service_creation	0%	false	false	false	3	3	github.com/smartcontractkit/chainlink/v2/core/services/job	false	10ms	@smartcontractkit/foundations, @smartcontractkit/core
TestRunner/test_job_spec_error_is_created	0%	false	false	false	3	3	github.com/smartcontractkit/chainlink/v2/core/services/job	false	0s	@smartcontractkit/foundations, @smartcontractkit/core
TestRunner/test_min_bootstrap	0%	false	false	false	3	3	github.com/smartcontractkit/chainlink/v2/core/services/job	false	0s	@smartcontractkit/foundations, @smartcontractkit/core
TestRunner/test_min_non-bootstrap	0%	false	false	false	3	3	github.com/smartcontractkit/chainlink/v2/core/services/job	false	0s	@smartcontractkit/foundations, @smartcontractkit/core
TestRunner/timeouts	0%	false	false	false	3	3	github.com/smartcontractkit/chainlink/v2/core/services/job	false	0s	@smartcontractkit/foundations, @smartcontractkit/core
TestSpawner_CreateJobDeleteJob	0%	false	false	false	3	3	github.com/smartcontractkit/chainlink/v2/core/services/job	false	380ms	@smartcontractkit/foundations, @smartcontractkit/core
TestSpawner_CreateJobDeleteJob/Unregisters_filters_on_'DeleteJob()'	0%	false	false	false	3	3	github.com/smartcontractkit/chainlink/v2/core/services/job	false	10ms	@smartcontractkit/foundations, @smartcontractkit/core
Test_FindJob	0%	false	false	false	3	3	github.com/smartcontractkit/chainlink/v2/core/services/job	false	93.333333ms	@smartcontractkit/foundations, @smartcontractkit/core

Artifacts

For detailed logs of the failed tests, please refer to the artifact failed-test-results-with-logs.json.

cl-sonarqube-production · 2025-03-14T14:32:39Z

Quality Gate passed

Issues
2 New issues
8 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
9.4% Duplication on New Code

See analysis details on SonarQube

github-actions · 2025-05-17T00:18:05Z

This PR is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 7 days.

samsondav force-pushed the MERC-6785 branch 4 times, most recently from 70f1dbe to dd54f46 Compare January 21, 2025 18:28

samsondav added the do-not-merge-yet label Jan 21, 2025

samsondav force-pushed the MERC-6785 branch 2 times, most recently from 32cf4d5 to 84afb33 Compare January 23, 2025 16:46

smartcontractkit deleted a comment from github-actions bot Jan 23, 2025

samsondav force-pushed the MERC-6785 branch from 84afb33 to 8f48b10 Compare January 23, 2025 16:50

samsondav force-pushed the MERC-6785 branch 3 times, most recently from b84750e to d9253da Compare January 23, 2025 19:23

samsondav force-pushed the MERC-6785 branch 3 times, most recently from 1a99108 to abad08c Compare February 11, 2025 15:36

samsondav force-pushed the MERC-6785 branch 6 times, most recently from c113ab5 to becd1db Compare February 11, 2025 18:02

samsondav force-pushed the MERC-6785 branch from becd1db to 28db39a Compare February 27, 2025 17:13

samsondav added 2 commits March 13, 2025 08:48

Remove legacy Mercury plugin and associated code

b8b092f

Remove wsrpc

a9ef8d4

samsondav force-pushed the MERC-6785 branch 2 times, most recently from 6a73419 to a9ef8d4 Compare March 14, 2025 14:22

github-actions bot added the Stale label May 17, 2025

github-actions bot closed this Jun 6, 2025

github-actions bot deleted the MERC-6785 branch June 6, 2025 00:18

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Remove legacy Mercury plugin and associated code #16014

Remove legacy Mercury plugin and associated code #16014

Uh oh!

samsondav commented Jan 21, 2025 •

edited

Loading

Uh oh!

github-actions bot commented Jan 23, 2025 •

edited

Loading

Uh oh!

github-actions bot commented Feb 11, 2025

Uh oh!

cl-sonarqube-production bot commented Mar 14, 2025

Uh oh!

github-actions bot commented May 17, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Remove legacy Mercury plugin and associated code #16014

Remove legacy Mercury plugin and associated code #16014

Uh oh!

Conversation

samsondav commented Jan 21, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Jan 23, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

AER Report: CI Core

1. Missing required module:

[test-scripts] Run Tests

[Core Tests (go_core_tests_integration)] Run tests

[Core Tests (go_core_ccip_deployment_tests)] Run tests

[Core Tests (go_core_fuzz)] Run tests

[Core Tests (go_core_tests)] Run tests

2. Undefined fields or methods:

[GolangCI Lint (.)] Golang Lint (.)

AER Report: Operator UI CI ran successfully ✅

Uh oh!

github-actions bot commented Feb 11, 2025

Flakeguard Summary

Found Flaky Tests ❌

Artifacts

Uh oh!

cl-sonarqube-production bot commented Mar 14, 2025

Quality Gate passed

Uh oh!

github-actions bot commented May 17, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

samsondav commented Jan 21, 2025 •

edited

Loading

github-actions bot commented Jan 23, 2025 •

edited

Loading