Create a prebuilt plugins Dockerfile #17583
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erikburt
previously approved these changes
May 6, 2025
krebernisak
reviewed
May 12, 2025
krebernisak
reviewed
May 12, 2025
jmank88
reviewed
May 12, 2025
| ARG PKG_PATH=./build | ||
|
|
||
| # Copy/override any (optional) additional shared libraries. | ||
| COPY ${PKG_PATH}/li[b] /usr/lib/ |
There was a problem hiding this comment.
Are the square brackets some kind of well known hack?
There was a problem hiding this comment.
Yeah, added a comment to clarify this in 4291268.
There was a problem hiding this comment.
It's a "hack" to make lib COPY optional (don't fail if ${PKG_PATH}/lib doesn't exist), suggested here: https://stackoverflow.com/a/76040555
chainchad
changed the title
erikburt
approved these changes
May 12, 2025
|
jmank88
approved these changes
May 12, 2025
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will allow other plugin repos like e.g.
chainlink-aptosto run this Dockerfile in their CI and copy in pre-built plugin binaries and libs into a newly built Chainlink node image for their integration testing.Relevant TON PR using this shared Dockerfile: https://github.com/smartcontractkit/chainlink-ton/pull/7 (loc ref)