Migrate Keystone View to Datastore API #17617
Conversation
vyzaldysanchez
force-pushed
the
task/CRE-400/refactor-keystone-view-with-datastore
branch
from
ee4bc0b to
c09071b
Compare
…tor-keystone-view-with-datastore
| CapabilitiesRegistry map[common.Address]*capabilities_registry.CapabilitiesRegistry | ||
| WorkflowRegistry map[common.Address]*workflow_registry.WorkflowRegistry | ||
| } | ||
|
|
||
| func ViewKeystone(e deployment.Environment, previousView json.Marshaler) (json.Marshaler, error) { |
There was a problem hiding this comment.
changes look good, let's add a test that ensures we get the expected result when there are multiple contracts of the same type on a single chain
Flakeguard SummaryRan new or updated tests between View Flaky Detector Details | Compare Changes Found Flaky Tests ❌1 Results
ArtifactsFor detailed logs of the failed tests, please refer to the artifact failed-test-results-with-logs.json. |
| require.Len(t, viewChain.WorkflowRegistry, 2) | ||
| _, ok = viewChain.CapabilityRegistry[capabilityRegistryAddr] | ||
| require.True(t, ok) | ||
| require.Len(t, viewChain.CapabilityRegistry, 1) |
There was a problem hiding this comment.
can we add a 2nd cap reg please? use case is active-active setup for aptos datafeeds; they require 2 capability registries
|
Flakeguard SummaryRan new or updated tests between View Flaky Detector Details | Compare Changes Found Flaky Tests ❌1 Results
ArtifactsFor detailed logs of the failed tests, please refer to the artifact failed-test-results-with-logs.json. |
vyzaldysanchez
deleted the
task/CRE-400/refactor-keystone-view-with-datastore
branch
This PR addresses CRE-400.
Currently, the Keystone View uses the Address Book to load the contracts and generate the View, but we want to refactor the functionality so it uses the newly added Datastore API.
Requires
Supports