Skip to content

feature(deployment): Aptos deploy CCIP CS #17625

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
May 15, 2025
Merged

Conversation

rodrigombsoares
Copy link
Contributor

Supports

#17046

Summary

This PR adds changesets to deploy an Aptos chain in CCIP.
It is a breakdown of #17046 only with CCIP Package deployment changesets.

Features

  • Deploys MCMS with Timelock
  • Configures MCMS Timelock
  • Deploys CCIP Package
  • Deploys CCIP Modules
  • Configures CCIP Modules

Testing

Unit tests in cs_deploy_aptos_chain_test.go uses CTF to spin up Aptos chain

Review Instructions

@rodrigombsoares rodrigombsoares force-pushed the aptos-deploy-ccip-cs branch from 8d222b6 to 8a1f1c9 Compare May 8, 2025 20:45
@rodrigombsoares rodrigombsoares requested a review from a team as a code owner May 8, 2025 20:45
Copy link
Contributor

github-actions bot commented May 8, 2025

Flakeguard Summary

Ran new or updated tests between develop and 8a1f1c9 (aptos-deploy-ccip-cs).

View Flaky Detector Details | Compare Changes

Found Flaky Tests ❌

3 Results
Name Pass Ratio Panicked? Timed Out? Race? Runs Successes Failures Skips Package Package Panicked? Avg Duration Code Owners
TestDeployAptosChainImp_VerifyPreconditions/error_-_invalid_config_for_chain 0% false false false 3 0 3 0 github.com/smartcontractkit/chainlink/deployment/ccip/changeset/aptos false 0s @smartcontractkit/ccip-tooling, @smartcontractkit/ccip-offchain, @smartcontractkit/core, @smartcontractkit/deployment-automation, @smartcontractkit/cld-team
TestDeployAptosChainImp_VerifyPreconditions/error_-_missing_MCMS_config_for_chain_without_MCMS_deployed 0% false false false 3 0 3 0 github.com/smartcontractkit/chainlink/deployment/ccip/changeset/aptos false 0s @smartcontractkit/ccip-tooling, @smartcontractkit/ccip-offchain, @smartcontractkit/core, @smartcontractkit/deployment-automation, @smartcontractkit/cld-team
TestDeployAptosChain_Apply 0% false false false 3 0 3 0 github.com/smartcontractkit/chainlink/deployment/ccip/changeset/aptos false 2m30.116666666s @smartcontractkit/ccip-tooling, @smartcontractkit/ccip-offchain, @smartcontractkit/core, @smartcontractkit/deployment-automation, @smartcontractkit/cld-team

Artifacts

For detailed logs of the failed tests, please refer to the artifact failed-test-results-with-logs.json.

Copy link
Collaborator

@graham-chainlink graham-chainlink left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice usage of Operations API!

Just wanted to mention that the recent version of Operations API, retry is no longer enable by default.

To enable it, refer https://docs.cld.cldev.sh/guides/changesets/operations-api#-common-patterns

@erikburt erikburt requested a review from a team as a code owner May 14, 2025 19:05
@erikburt erikburt force-pushed the aptos-deploy-ccip-cs branch from e53d876 to 603ae24 Compare May 14, 2025 19:15
chainchad
chainchad previously approved these changes May 14, 2025
Copy link
Contributor

Flakeguard Summary

Ran new or updated tests between develop and 2f4cb72 (aptos-deploy-ccip-cs).

View Flaky Detector Details | Compare Changes

Found Flaky Tests ❌

1 Results
Name Pass Ratio Panicked? Timed Out? Race? Runs Successes Failures Skips Package Package Panicked? Avg Duration Code Owners
TestDeployAptosChain_Apply 0% false false false 3 0 3 0 github.com/smartcontractkit/chainlink/deployment/ccip/changeset/aptos false 48.863333333s @smartcontractkit/ccip-tooling, @smartcontractkit/ccip-offchain, @smartcontractkit/core, @smartcontractkit/deployment-automation, @smartcontractkit/cld-team

Artifacts

For detailed logs of the failed tests, please refer to the artifact failed-test-results-with-logs.json.

@cl-sonarqube-production
Copy link

@FelixFan1992 FelixFan1992 added this pull request to the merge queue May 15, 2025
Merged via the queue into develop with commit 264547f May 15, 2025
144 of 145 checks passed
@FelixFan1992 FelixFan1992 deleted the aptos-deploy-ccip-cs branch May 15, 2025 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants