Skip to content

Add Loop-compatible Head Reporter for Solana (#17580) #17627

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: release/2.23.1-ccip
Choose a base branch
from

Conversation

reductionista
Copy link
Contributor

@reductionista reductionista commented May 7, 2025

cherry-pick of #17580 , so it's ready in case we need a hot fix for 2.23.1-ccip release before 2.24.0 is ready

* Add Solana Head Reporter

* Add explanation to //golint:nosec

* Address PR comments

Renames:
- NewEVMTelemetry -> NewLegacyEVMTelemetry
- NewPrometheusReporter -> NewLegacyEVMPrometheusReporter
- evmTelemetryReporter -> legacyEVMTelemetryReporter
- NewSolanaTelemetryReporter -> NewTelemetryReporter
- solanaTelemetryReporter -> loopTelemetryReporter

Now, NewTelemetryReporter handles all relayers in the same way
(including EVM). The legacy EVM Telemetry Reporter is left operational
so we still receive metrics about finalized heads. This can be removed
once we extend the relayer interface to be able to fetch finalized heads
from there.

* Remove unused error output from GetIDToRelayerMap()
Copy link
Contributor

github-actions bot commented May 7, 2025

I see you updated files related to core. Please run pnpm changeset in the root directory to add a changeset as well as in the text include at least one of the following tags:

  • #added For any new functionality added.
  • #breaking_change For any functionality that requires manual action for the node to boot.
  • #bugfix For bug fixes.
  • #changed For any change to the existing functionality.
  • #db_update For any feature that introduces updates to database schema.
  • #deprecation_notice For any upcoming deprecation functionality.
  • #internal For changesets that need to be excluded from the final changelog.
  • #nops For any feature that is NOP facing and needs to be in the official Release Notes for the release.
  • #removed For any functionality/config that is removed.
  • #updated For any functionality that is updated.
  • #wip For any change that is not ready yet and external communication about it should be held off till it is feature complete.

🎖️ No JIRA issue number found in: PR title, commit message, or branch name. Please include the issue ID in one of these.

@cl-sonarqube-production
Copy link

@reductionista reductionista marked this pull request as ready for review May 8, 2025 16:40
@reductionista reductionista requested review from a team as code owners May 8, 2025 16:40
@reductionista reductionista requested review from EasterTheBunny, winder, asoliman92, matYang, makramkd, dimkouv, mateusz-sekara and b-gopalswami and removed request for a team May 8, 2025 16:40
@reductionista
Copy link
Contributor Author

Note: fuzz test failures are fixed by these 14 commits, but doesn't seem worth pulling all of that into release branch to get a non-required test to pass and making partial changes manually instead will cause future merge conflicts.

commit 915a804629d95ed156c3a5fa346b125158e9a4aa
Author: Erik Burton <[email protected]>
Date:   Fri Apr 25 14:06:22 2025 -0700

    feat: runs-on CI fuzz tests (#17451)

commit 1daaae4836ec0e827c94035bc61e105e599cc4c5
Author: Lukasz <[email protected]>
Date:   Wed Apr 23 16:10:51 2025 +0200

    Disable Flakeguard for PR for core unit tests (#17386)
    
    * Disable Flakeguard for core unit tests
    
    Disable it until https://smartcontract-it.atlassian.net/browse/DX-379 is done.
    
    * Skip flaky test
    
    * Revert "Skip flaky test"
    
    This reverts commit 85f802d7b8809958bebec17ff2ea7493d3d98bbc.
    
    * Run flakeguard only on merge group

commit 47375728b7284f3733f5e032c362d54a29da6996
Author: chainchad <[email protected]>
Date:   Mon Apr 21 12:50:09 2025 -0400

    Use loopinstall to install plugins on plugins Docker image (#17252)
    
    * WIP
    
    * Use loopinstall to install plugins
    
    * Use docker cache mounts for core Dockerfile
    
    * Fix goreleaser ref to make target
    
    * Provide CL_APTOS_CMD build arg
    
    * Remove defaults.goprivate and set defaults.goflags
    
    * Fix typos
    
    * Update goreleaser to install loopinstall in its own step
    
    * Fix goflags syntax
    
    * Bump chainlink-common to latest and run tidy
    
    * Use version of loopinstall from chainlink-common in go.mod
    
    * Revert "Bump chainlink-common to latest and run tidy"
    
    This reverts commit 2a1546712990c65fc1c9545a6a01597957d03188.
    
    * Use version of loopinstall from chainlink-common in go.mod (post develop merge)
    
    * Set GOPRIVATE within private plugins target
    
    * Add CCIP specific config back
    
    * Update chainlink-solana plugin to match version in go.mod
    
    * Update plugins gitRef to the go.mod pseudo-version
    
    * Create plugout tool to check for out of sync plugins (#17360)

commit dde14319b9f586d412069924db0fb018d7a05dab
Author: Erik Burton <[email protected]>
Date:   Fri Apr 18 13:42:01 2025 -0700

    fix: ci-core runner-config (#17356)

commit c12ad1688ec7b4be167af93d4aa3d91f46680563
Author: Erik Burton <[email protected]>
Date:   Fri Apr 18 13:11:17 2025 -0700

    chore: cleanup ci-core (#17332)

commit 89be6b899ecedbef43060006eaf9b906f2aeebcb
Author: Erik Burton <[email protected]>
Date:   Thu Apr 17 09:58:02 2025 -0700

    feat: runs-on 100% allocation (#17308)
    
    * feat: runs-on 100% allocation
    
    * feat: s3 go module cache

commit 5c55d764a82672eaf256521bc02cc78b4e5c0ecb
Author: Erik Burton <[email protected]>
Date:   Tue Apr 15 18:41:51 2025 -0700

    feat: runs-on 75% allocation (#17271)

commit c133281aee8a630af6d43511c5e7565d69947449
Author: Erik Burton <[email protected]>
Date:   Fri Apr 11 14:22:47 2025 -0700

    chore: optimize go build cache (#17248)

commit 5f40db9304e2294c961f02c8fc3e4065f7e1608f
Author: Erik Burton <[email protected]>
Date:   Fri Apr 11 13:14:31 2025 -0700

    feat: runs-on 50% allocation (#17230)

commit 0f16f5a4cbcb9035a14d3ee773df0ccbae7b7572
Author: Erik Burton <[email protected]>
Date:   Fri Apr 11 08:41:14 2025 -0700

    fix: runs-on tmp mount (#17232)

commit 1e6d1483f04fffcd112b13c7541f6cff53143775
Author: Erik Burton <[email protected]>
Date:   Thu Apr 10 20:16:17 2025 -0700

    feat: runs-on scheduled events (#17227)

commit 5ec5347da73ce27fb6cdbf46e01204396b1f8e07
Author: Erik Burton <[email protected]>
Date:   Wed Apr 9 21:00:29 2025 -0700

    feat: runs-on 25% allocation (#17184)
    
    * feat: runs-on 25% allocation
    
    * fix: comment

commit 0911121788a3bfbd9b884c9d528022402eb83ff2
Author: Erik Burton <[email protected]>
Date:   Wed Apr 9 14:51:48 2025 -0700

    fix: runs-on mount /tmp (#17212)

commit 695974b259c5462289ba8a0185306db28b6ad400
Author: Erik Burton <[email protected]>
Date:   Wed Apr 9 09:45:33 2025 -0700

    fix: runs-on stability (#17207)
    ```

@reductionista reductionista changed the title Add Solana Head Reporter (#17580) Add Loop-compatible Head Reporter for Solana (#17580) May 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants