Skip to content

chore: skip flaky tests #17675

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
krehermann merged 5 commits into from
May 13, 2025
Merged

chore: skip flaky tests #17675

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
738e90b
chore: skip flaky tests
erikburt May 12, 2025
fe9a17b
fix: skip subsequent tests for TestKeystoneView
erikburt May 12, 2025
c0da446
Merge branch 'develop' into chore/skip-flaky-tests-may-12
erikburt May 12, 2025
14f712c
Merge branch 'develop' into chore/skip-flaky-tests-may-12
erikburt May 13, 2025
c2524dc
fix: unused import error
erikburt May 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions core/capabilities/remote/executable/client_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,6 +84,7 @@ func Test_Client_DonTopologies(t *testing.T) {
}

func Test_Client_TransmissionSchedules(t *testing.T) {
tests.SkipFlakey(t, "https://smartcontract-it.atlassian.net/browse/DX-104")
ctx := testutils.Context(t)

responseTest := func(t *testing.T, response commoncap.CapabilityResponse, responseError error) {
Expand Down
2 changes: 2 additions & 0 deletions core/services/ocrcommon/peer_wrapper_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@ import (

commonconfig "github.com/smartcontractkit/chainlink-common/pkg/config"
"github.com/smartcontractkit/chainlink-common/pkg/services/servicetest"
"github.com/smartcontractkit/chainlink-common/pkg/utils/tests"
"github.com/smartcontractkit/chainlink/v2/core/internal/cltest"
"github.com/smartcontractkit/chainlink/v2/core/internal/testutils"
"github.com/smartcontractkit/chainlink/v2/core/internal/testutils/configtest"
Expand Down Expand Up @@ -109,6 +110,7 @@ func Test_SingletonPeerWrapper_Start(t *testing.T) {
}

func Test_SingletonPeerWrapper_Close(t *testing.T) {
tests.SkipFlakey(t, "https://smartcontract-it.atlassian.net/browse/DX-761")
t.Parallel()
ctx := testutils.Context(t)

Expand Down
8 changes: 8 additions & 0 deletions deployment/ccip/changeset/crossfamily/v1_6/cs_add_evm_solana_lane_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,8 @@ import (
solState "github.com/smartcontractkit/chainlink-ccip/chains/solana/utils/state"
"github.com/smartcontractkit/chainlink-testing-framework/lib/utils/testcontext"

"github.com/smartcontractkit/chainlink-common/pkg/utils/tests"

crossfamily "github.com/smartcontractkit/chainlink/deployment/ccip/changeset/crossfamily/v1_6"
ccipChangesetSolana "github.com/smartcontractkit/chainlink/deployment/ccip/changeset/solana"
"github.com/smartcontractkit/chainlink/deployment/ccip/changeset/testhelpers"
Expand All @@ -40,6 +42,12 @@ func TestAddEVMSolanaLaneBidirectional(t *testing.T) {
},
} {
t.Run(tc.name, func(t *testing.T) {
if t.Name() == "TestAddEVMSolanaLaneBidirectional/MCMS_enabled" {
tests.SkipFlakey(t, "https://smartcontract-it.atlassian.net/browse/DX-758")
}
if t.Name() == "TestAddEVMSolanaLaneBidirectional/MCMS_disabled" {
tests.SkipFlakey(t, "https://smartcontract-it.atlassian.net/browse/DX-759")
}
t.Parallel()
ctx := testcontext.Get(t)
tenv, _ := testhelpers.NewMemoryEnvironment(t, testhelpers.WithSolChains(1))
Expand Down
2 changes: 2 additions & 0 deletions deployment/common/changeset/solana/update_delay_timelock_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@ import (
"go.uber.org/zap/zapcore"

timelockBindings "github.com/smartcontractkit/chainlink-ccip/chains/solana/gobindings/timelock"
"github.com/smartcontractkit/chainlink-common/pkg/utils/tests"

chainselectors "github.com/smartcontractkit/chain-selectors"
mcmsSolana "github.com/smartcontractkit/mcms/sdk/solana"
Expand Down Expand Up @@ -174,6 +175,7 @@ func TestUpdateTimelockDelaySolana_VerifyPreconditions(t *testing.T) {
}

func TestUpdateTimelockDelaySolana_Apply(t *testing.T) {
tests.SkipFlakey(t, "https://smartcontract-it.atlassian.net/browse/DX-762")
t.Parallel()
env := setupUpdateDelayTestEnv(t)
newDelayDuration := 5 * time.Minute
Expand Down
3 changes: 3 additions & 0 deletions deployment/common/changeset/transfer_to_mcms_with_timelock_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,8 @@ import (
chain_selectors "github.com/smartcontractkit/chain-selectors"
"github.com/stretchr/testify/require"

"github.com/smartcontractkit/chainlink-common/pkg/utils/tests"

cldf "github.com/smartcontractkit/chainlink-deployments-framework/deployment"
"github.com/smartcontractkit/chainlink/deployment"
"github.com/smartcontractkit/chainlink/deployment/common/proposalutils"
Expand Down Expand Up @@ -150,6 +152,7 @@ func TestTransferToMCMSWithTimelockV2(t *testing.T) {
}

func TestRenounceTimelockDeployerConfigValidate(t *testing.T) {
tests.SkipFlakey(t, "https://smartcontract-it.atlassian.net/browse/DX-724")
t.Parallel()
lggr := logger.TestLogger(t)
e := memory.NewMemoryEnvironment(t, lggr, 0, memory.MemoryEnvironmentConfig{
Expand Down
Loading