Skip to content

[PRODCRE-1077] Flag for local capabilities + Launcher metrics #19919

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 17, 2025
Merged

[PRODCRE-1077] Flag for local capabilities + Launcher metrics #19919

merged 1 commit into from
Oct 17, 2025

Conversation

bolekk
Copy link
Contributor

@bolekk bolekk commented Oct 16, 2025 •
edited
Loading

Explicitly mark capabilities as local and skip them in Launcher (depends on smartcontractkit/chainlink-common#1616)

Additionally export a few new metrics from Launcher.

Also had to bump go to 1.25 with the new common.

@github-actions GitHub Actions
Copy link
Contributor

I see you updated files related to core. Please run pnpm changeset in the root directory to add a changeset as well as in the text include at least one of the following tags:

  • #added For any new functionality added.
  • #breaking_change For any functionality that requires manual action for the node to boot.
  • #bugfix For bug fixes.
  • #changed For any change to the existing functionality.
  • #db_update For any feature that introduces updates to database schema.
  • #deprecation_notice For any upcoming deprecation functionality.
  • #internal For changesets that need to be excluded from the final changelog.
  • #nops For any feature that is NOP facing and needs to be in the official Release Notes for the release.
  • #removed For any functionality/config that is removed.
  • #updated For any functionality that is updated.
  • #wip For any change that is not ready yet and external communication about it should be held off till it is feature complete.

@bolekk bolekk force-pushed the feature/PRODCRE-1077-local-only-flag branch 6 times, most recently from e0f12ea to 9e7a5e0 Compare October 16, 2025 20:33
patrickhuie19
patrickhuie19 reviewed Oct 16, 2025
View reviewed changes
go.mod
module github.com/smartcontractkit/chainlink/v2

go 1.24.5
go 1.25.3
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is anything forcing a go bump? or you just think its about time?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah, new common is set to 1.25

@bolekk bolekk force-pushed the feature/PRODCRE-1077-local-only-flag branch from 9e7a5e0 to 73745bd Compare October 16, 2025 21:06
bolekk
bolekk commented Oct 16, 2025
View reviewed changes
core/services/gateway/network/httpclient_test.go
expectedError: "no such host",
},
{
/*{ // TODO: failing with go 1.25
Copy link
Contributor Author

@bolekk bolekk Oct 16, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cedric-cordenier / @jmank88 - any idea why these started to break with Go 1.25? In playground they don't work with either... https://go.dev/play/p/XYO2ekdS5bx?v=goprev

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

even weirder: tip does not error!

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Likely this? golang/go#75713
Only in newer patch release of 1.24 and 1.25

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed yesterday: golang/go#75815

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wow good find thanks!

@bolekk bolekk marked this pull request as ready for review October 16, 2025 21:26
@bolekk bolekk requested review from a team as code owners October 16, 2025 21:26
@cl-sonarqube-production
Copy link

Quality Gate passed Quality Gate passed

Issues
3 New issues
4 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube

@jmank88 jmank88 requested a review from patrickhuie19 October 17, 2025 00:02
@jmank88 jmank88 mentioned this pull request Oct 17, 2025
Closed
@bolekk bolekk enabled auto-merge October 17, 2025 00:13
@bolekk bolekk added this pull request to the merge queue Oct 17, 2025
Merged via the queue into develop with commit 91796e2 Oct 17, 2025
287 of 295 checks passed
@bolekk bolekk deleted the feature/PRODCRE-1077-local-only-flag branch October 17, 2025 00:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jmank88 jmank88 jmank88 approved these changes

@vyzaldysanchez vyzaldysanchez vyzaldysanchez approved these changes

@erikburt erikburt Awaiting requested review from erikburt

@ecPablo ecPablo Awaiting requested review from ecPablo

@pavel-raykov pavel-raykov Awaiting requested review from pavel-raykov

@justinkaseman justinkaseman Awaiting requested review from justinkaseman

@patrickhuie19 patrickhuie19 Awaiting requested review from patrickhuie19

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@bolekk @jmank88 @vyzaldysanchez @patrickhuie19