-
Notifications
You must be signed in to change notification settings - Fork 1.9k
feat(ci): plugout improvements #19929
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Please, consider reenabling tron-relayer check disabled here 5659eb4 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Adds auto-discovery of plugin modules from YAML, refactors sync logic to use go list -m for version resolution, and introduces an ignore-module flag while removing manual --module usage.
- Auto-discovers modules from plugin YAML instead of requiring repeated --module flags.
- Adds --ignore-module support and refactors runSync to return mismatch status; updates CI workflow accordingly.
- Replaces manual go.mod parsing with go list -m -json based normalization and expands test coverage (tags, SHAs, submodule handling).
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
File | Description |
---|---|
tools/plugout/main.go | Core refactor: options struct, discovery, version normalization, exec-based module version resolution, ignore logic. |
tools/plugout/main_test.go | Expanded unit tests for normalization, matching, YAML update, end-to-end sync modes. |
tools/plugout/README.md | Updates CLI options removing --module, documents --ignore-module. |
.github/workflows/ci-core.yml | Simplifies plugout invocation by removing explicit --module arguments and names Go setup step. |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
|
Changes
--ignore-modules
parameter to exclude modules as needed. Now "opt-out"v0.0.11-0.20250908203554-5bd9d2fe9513
vs.5d9d2fe9513fae7d0afb3a17e4bbc80a839dfc5
)go list -m -json ...
instead of trying to manually parsing ago.mod
file--update
Motivation
This is motivated by a few things:
Testing
Updated unit tests, validated locally, https://github.com/smartcontractkit/chainlink/actions/runs/18572518994/job/52949698047?pr=19929
Tested indirect dependency skipping locally due to #19933 / #19932
Output
Example Output