chore: update deployment/common MCMS tests #19943
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jkongie
requested review from
0xAustinWang,
agusaldasoro,
matYang,
mateusz-sekara,
ogtownsend,
tt-cll and
winder
product-security-plaid-production
bot
requested review from
Tofel,
ajaskolski and
archseer
jkongie
force-pushed
the
CLD-730/update-common-mcms-tests
branch
from
86b0447 to
938656c
Compare
jkongie
commented
Oct 17, 2025
Comment on lines
-293
to
-315
| evmSelectors[1]: { | ||
| Proposer: mcmstypes.Config{ | ||
| Quorum: 1, | ||
| Signers: []common.Address{common.HexToAddress("0x0000000000000000000000000000000000000011")}, | ||
| GroupSigners: []mcmstypes.Config{}, | ||
| }, | ||
| Canceller: mcmstypes.Config{ | ||
| Quorum: 2, | ||
| Signers: []common.Address{ | ||
| common.HexToAddress("0x0000000000000000000000000000000000000012"), | ||
| common.HexToAddress("0x0000000000000000000000000000000000000013"), | ||
| common.HexToAddress("0x0000000000000000000000000000000000000014"), | ||
| }, | ||
| GroupSigners: []mcmstypes.Config{}, | ||
| }, | ||
| Bypasser: mcmstypes.Config{ | ||
| Quorum: 1, | ||
| Signers: []common.Address{common.HexToAddress("0x0000000000000000000000000000000000000005")}, | ||
| GroupSigners: []mcmstypes.Config{}, | ||
| }, | ||
| TimelockMinDelay: big.NewInt(1), | ||
| }, | ||
| solanaSelectors[0]: { |
There was a problem hiding this comment.
There is no need to test 2 evm deploys, so removed the second one
jkongie
commented
Oct 17, 2025
| newCfgBypasser.Signers = append(newCfgBypasser.Signers, signer1Addr) | ||
| newCfgBypasser.Quorum = 2 | ||
|
|
||
| t.Run("MCMS disabled", func(t *testing.T) { |
There was a problem hiding this comment.
Changed to run sequentially so that we only have to boot a single container
jkongie
commented
Oct 17, 2025
Comment on lines
-196
to
-209
| func SetPreloadedSolanaAddresses(t *testing.T, env cldf.Environment, selector uint64) { | ||
| typeAndVersion := cldf.NewTypeAndVersion(commontypes.ManyChainMultisigProgram, deployment.Version1_0_0) | ||
| err := env.ExistingAddresses.Save(selector, memory.SolanaProgramIDs["mcm"], typeAndVersion) | ||
| require.NoError(t, err) | ||
|
|
||
| typeAndVersion = cldf.NewTypeAndVersion(commontypes.AccessControllerProgram, deployment.Version1_0_0) | ||
| err = env.ExistingAddresses.Save(selector, memory.SolanaProgramIDs["access_controller"], typeAndVersion) | ||
| require.NoError(t, err) | ||
|
|
||
| typeAndVersion = cldf.NewTypeAndVersion(commontypes.RBACTimelockProgram, deployment.Version1_0_0) | ||
| err = env.ExistingAddresses.Save(selector, memory.SolanaProgramIDs["timelock"], typeAndVersion) | ||
| require.NoError(t, err) | ||
| } | ||
|
|
There was a problem hiding this comment.
Replaced by the soltestutils package
jkongie
commented
Oct 17, 2025
Comment on lines
-63
to
-64
| quarantine.Flaky(t, "DX-1873") | ||
| quarantine.Flaky(t, "DX-1811") |
There was a problem hiding this comment.
This is now fixed because we get rid of the booting of the solana container
|
|
||
| func TestTransferFromTimelockConfig_Apply(t *testing.T) { | ||
| quarantine.Flaky(t, "DX-1754") | ||
| // quarantine.Flaky(t, "DX-1754") |
There was a problem hiding this comment.
do we want to do this?
|
|
||
| func TestTransferToMCMSToTimelockSolana(t *testing.T) { | ||
| quarantine.Flaky(t, "DX-1773") | ||
| // quarantine.Flaky(t, "DX-1773") |
There was a problem hiding this comment.
this too? Do we want to uncomment it?
| env := memory.NewMemoryEnvironment(t, lggr, zapcore.DebugLevel, cfg) | ||
| chainSelector := env.BlockChains.ListChainSelectors(cldf_chain.WithFamily(chain_selectors.FamilyEVM))[0] | ||
| chainSelectorSolana := env.BlockChains.ListChainSelectors(cldf_chain.WithFamily(chain_selectors.FamilySolana))[0] | ||
| // quarantine.Flaky(t, "DX-1824") |
jkongie
force-pushed
the
CLD-730/update-common-mcms-tests
branch
6 times, most recently
from
de38de8 to
94bfd1b
Compare
This commit updates the remaining deployment/common MCMS tests to use the test engine runtime. This commit also adds a new soltestutils package to help with preloading MCMS programs and funding accounts.
jkongie
force-pushed
the
CLD-730/update-common-mcms-tests
branch
from
94bfd1b to
a431e9e
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates the remaining deployment/common MCMS tests to use the test engine runtime.
This also adds a new soltestutils package to help with preloading MCMS programs and funding accounts.