CCIP-7724 leave from field empty when perform method read

[Unheilbar]

JIRA

Execution clients with REVM backend apply EIP-3607 (reject caller with code) even for eth_call's, therefore when to address is a contract, our calls fail.
There is no practical reasons to set from = to address for eth_call's.

[github-actions]

I see you updated files related to core. Please run pnpm changeset in the root directory to add a changeset as well as in the text include at least one of the following tags:

• #added For any new functionality added.
• #breaking_change For any functionality that requires manual action for the node to boot.
• #bugfix For bug fixes.
• #changed For any change to the existing functionality.
• #db_update For any feature that introduces updates to database schema.
• #deprecation_notice For any upcoming deprecation functionality.
• #internal For changesets that need to be excluded from the final changelog.
• #nops For any feature that is NOP facing and needs to be in the official Release Notes for the release.
• #removed For any functionality/config that is removed.
• #updated For any functionality that is updated.
• #wip For any change that is not ready yet and external communication about it should be held off till it is feature complete.

[cl-sonarqube-production]

Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarQube

[pavel-raykov]

can we add a test for that? (also with the comment from JIRA why we do that)

[Unheilbar]

I added a summary to the PR description.
What would the test look like? We have higher level tests that use method read under the hood.

[pavel-raykov]

Judging by the JIRA, it seems essential that the From: is not set. Hence, it seems natural to enforce this behavior in tests (currently, no test would fail if someone introduces From: back)

[Unheilbar]

method.GetLatestValue is the only place where From can be set; that's where CallMsg is formed. I agree the test case would be reasonable if the scope of setting CallMsg.From were broader.
p.s. Also it's essential for the From not to be a contract address, we don't necessary need to enforce empty From via tests.

[pavel-raykov]

In the tests here

chainlink/core/services/relay/evm/chain_reader_test.go

Line 53 in 084d67c

tester := &simpleTester{returnVal: big.NewInt(42), internalType: test}

we essentially construct a chain_reader with a mocked client. Would it be possible to return the mocked client and insert an assertion that CallContract is called with not a contract address?