Skip to content

[CRE] Logging improvements#22285

Merged
bolekk merged 1 commit intodevelopfrom
logs_fixes_core
May 5, 2026
Merged

[CRE] Logging improvements#22285
bolekk merged 1 commit intodevelopfrom
logs_fixes_core

Conversation

@bolekk
Copy link
Copy Markdown
Contributor

@bolekk bolekk commented May 4, 2026 •
edited
Loading

  1. Better name for one Dispatcher metric.
  2. Cache calls to LocalNode to reduce redundant computation and noisy logs.
  3. Use labels in logs wherever possible.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 4, 2026

I see you updated files related to core. Please run make gocs in the root directory to add a changeset as well as in the text include at least one of the following tags:

  • #added For any new functionality added.
  • #breaking_change For any functionality that requires manual action for the node to boot.
  • #bugfix For bug fixes.
  • #changed For any change to the existing functionality.
  • #db_update For any feature that introduces updates to database schema.
  • #deprecation_notice For any upcoming deprecation functionality.
  • #internal For changesets that need to be excluded from the final changelog.
  • #nops For any feature that is NOP facing and needs to be in the official Release Notes for the release.
  • #removed For any functionality/config that is removed.
  • #updated For any functionality that is updated.
  • #wip For any change that is not ready yet and external communication about it should be held off till it is feature complete.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 4, 2026 •
edited
Loading

✅ No conflicts with other open PRs targeting develop

@trunk-io
Copy link
Copy Markdown

trunk-io Bot commented May 4, 2026 •
edited
Loading

Static Badge   Static Badge   Static Badge   Static Badge

View Full Report ↗︎ ⋅ Docs

@bolekk bolekk force-pushed the logs_fixes_core branch 2 times, most recently from 77db87a to b88627f Compare May 5, 2026 04:18
@bolekk bolekk marked this pull request as ready for review May 5, 2026 05:25
@bolekk bolekk requested review from a team as code owners May 5, 2026 05:25
jmank88
jmank88 reviewed May 5, 2026
View reviewed changes
Comment thread core/services/registrysyncer/local_registry.go Outdated
mchain0
mchain0 previously approved these changes May 5, 2026
View reviewed changes
@bolekk bolekk force-pushed the logs_fixes_core branch from b88627f to 0d68c11 Compare May 5, 2026 15:53
@bolekk bolekk enabled auto-merge May 5, 2026 16:00
@cl-sonarqube-production
Copy link
Copy Markdown

cl-sonarqube-production Bot commented May 5, 2026

Quality Gate passed Quality Gate passed

Issues
2 New issues
2 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube

@bolekk bolekk added this pull request to the merge queue May 5, 2026
@github-merge-queue github-merge-queue Bot removed this pull request from the merge queue due to failed status checks May 5, 2026
@bolekk bolekk added this pull request to the merge queue May 5, 2026
@github-merge-queue github-merge-queue Bot removed this pull request from the merge queue due to failed status checks May 5, 2026
@bolekk bolekk added this pull request to the merge queue May 5, 2026
@github-merge-queue github-merge-queue Bot removed this pull request from the merge queue due to failed status checks May 5, 2026
@bolekk bolekk added this pull request to the merge queue May 5, 2026
Merged via the queue into develop with commit b9cd7b2 May 5, 2026
211 of 213 checks passed
@bolekk bolekk deleted the logs_fixes_core branch May 5, 2026 18:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jmank88 jmank88 jmank88 approved these changes

@prashantkumar1982 prashantkumar1982 prashantkumar1982 approved these changes

@mchain0 mchain0 mchain0 left review comments

@MStreet3 MStreet3 Awaiting requested review from MStreet3

@patrickhuie19 patrickhuie19 Awaiting requested review from patrickhuie19

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@bolekk @jmank88 @prashantkumar1982 @mchain0