[DX-4045] Loopinstall Caching - #23285
Open
kalverra wants to merge 4 commits into
Open
Conversation
Contributor
|
✅ No conflicts with other open PRs targeting |
kalverra
force-pushed
the
loopinstallCaching
branch
from
July 30, 2026 22:33
8e381c7 to
454e0a2
Compare
kalverra
marked this pull request as ready for review
July 30, 2026 22:33
product-security-plaid-production
Bot
requested review from
patrickhuie19 and
skudasov
July 30, 2026 22:34
Contributor
There was a problem hiding this comment.
Pull request overview
Risk Rating: MEDIUM — Changes are confined to CI/workflow + composite actions, but they can affect CI correctness and reliability across many runs (cache correctness, module resolution, and tool installation).
This PR aims to reduce CI time spent running loopinstall by introducing a two-tier caching strategy (cached plugin binaries + cached Go build cache), and also standardizes/caches Aptos (and tweaks Solana caching) via composite actions.
Changes:
- Replace
make install-pluginssteps in CI with a new composite action that restores/saves cached LOOP plugin binaries and (on miss) a scoped Go build cache. - Replace direct Aptos CLI installation with a composite action that caches the installed binary.
- Adjust Solana setup caching strategy (path/key), and refactor deployment workflow setup steps.
Scrupulous human review recommended for:
- Cache key correctness vs. what is actually installed/built in:
.github/actions/setup-solana/action.yml(newversioninput vs installer script behavior).github/actions/setup-loop-plugins/action.yml(plugin-fileinput vsmake install-plugins-publicbehavior)
- Module resolution in
.github/workflows/ci-deployments.yml(go mod downloaddirectory vs configureddeployment/go.*inputs)
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| .github/workflows/ci-deployments.yml | Switches to composite actions for Aptos + LOOP plugins; adjusts module download and DB setup invocation. |
| .github/workflows/ci-core.yml | Switches Aptos + LOOP plugins setup to composite actions for reuse/caching. |
| .github/actions/setup-solana/action.yml | Updates Solana caching behavior and introduces a version input. |
| .github/actions/setup-loop-plugins/action.yml | New composite action implementing two-tier caching for LOOP plugin installation. |
| .github/actions/setup-aptos/action.yml | New composite action to install Aptos CLI with caching. |
Comment on lines
+159
to
+160
| - name: Download Go vendor packages | ||
| run: go mod download |
Comment on lines
+4
to
+7
| version: | ||
| description: Solana CLI version | ||
| required: false | ||
| default: v1.18.26 |
Comment on lines
+3
to
+7
| inputs: | ||
| plugin-file: | ||
| description: Path to public plugins file | ||
| required: false | ||
| default: plugins/plugins.public.yaml |
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Running
loopinstalltakes ~5 minutes in CI, and there's no proper caching for it. This PR adds it in two tiers.