-
Notifications
You must be signed in to change notification settings - Fork 9
2.7.2 #595
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
2.7.2 #595
Conversation
👋 mxiao-cll, thanks for creating this pull request! To help reviewers, please consider creating future PRs as drafts first. This allows you to self-review and make any final changes before notifying the team. Once you're ready, you can mark it as "Ready for review" to request feedback. Thanks! |
NPM Publishing labels 🏷️🟢 This PR has valid version labels and will cause a |
{ | ||
"name": "@chainlink/external-adapter-framework", | ||
"version": "2.7.1", | ||
"version": "2.7.2", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The PR description says we want to bump all EAs.
- Why do we need a framework version update for that?
- Can we use recently created version 2.7.1 for that?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The easiest way to bump EA is to bump the framework version, I am not sure if there is already EA on 2.7.1 so doing a framework bump here to be safe
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Only scripts
is at 2.7.1. Everything else is at 2.7.0.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok, I will not rush to merge this in then
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I need to release the framework for openexchangerate
🚀 Successfully ran preflight checks. |
We want to force bump all EAs in order for the new release workflow to kick-in and produce arm64 images.
For some reason the dependency check is blocked on this PR, I have enable it to run on PR as well to unblock. This check is checking that we use exact version instead of ^ or ~ so it is safe to run on PR