Skip to content

fix js-yaml vulnerability (transitive dependency) #678

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
karen-stepanyan wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix js-yaml vulnerability (transitive dependency) #678

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7ec23a3
fix js-yaml vulnerability (transitive dependency)
karen-stepanyan Feb 6, 2026
056e9c2
lock with supertap/js-yaml
karen-stepanyan Feb 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,6 +64,9 @@
"trailingComma": "all",
"arrowParens": "always"
},
"resolutions": {
"**/js-yaml": "3.14.2"
Copy link
Contributor

@alecgard alecgard Feb 6, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will this break the dependencies that need the next major version js-yaml@^4.1.0?

I'm wondering if we can instead only resolve the concerning version e.g.

"**/js-yaml@3.14.1": "^3.14.2"

Copy link
Contributor Author

@karen-stepanyan karen-stepanyan Feb 6, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think it will break, but I changed it to supertap/js-yaml which seems to be the issue. unfortunately ava dependency that we use is on latest version, but is using older dependency internally, so we have to use resolutions

Copy link
Contributor

@alecgard alecgard Feb 6, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there any issue with targeting 3.14.1 for resolution specifically? Rather than all versions of supertap/js-yaml

Copy link
Contributor

@alecgard alecgard Feb 6, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also can we use ^3.14.2, so we still pick up new versions?

Copy link
Contributor Author

@karen-stepanyan karen-stepanyan Feb 6, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

3.14.1 contains the vulnerability. the minimum version should be 3.14.2.
all of other deps are actually locked to a specific version, and we let depandabot or renovate bot to handle package updates.

},
"ava": {
"files": [
"test/**/*.test.ts"
Expand Down
15 changes: 4 additions & 11 deletions yarn.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2004,21 +2004,14 @@ js-string-escape@^1.0.1:
resolved "https://registry.npmjs.org/js-string-escape/-/js-string-escape-1.0.1.tgz"
integrity sha512-Smw4xcfIQ5LVjAOuJCvN/zIodzA/BBSsluuoSykP+lUvScIi4U6RJLfwHet5cxFnCswUjISV8oAXaqaJDY3chg==

js-yaml@^3.14.1:
version "3.14.1"
resolved "https://registry.npmjs.org/js-yaml/-/js-yaml-3.14.1.tgz"
integrity sha512-okMH7OXXJ7YrN9Ok3/SXrnu4iX9yOk+25nqX4imS2npuvTYDmo/QEZoqwZkYaIDk3jVvBOTOIEgEhaLOynBS9g==
js-yaml@3.14.2, js-yaml@^3.14.1, js-yaml@^4.1.0:
version "3.14.2"
resolved "https://registry.yarnpkg.com/js-yaml/-/js-yaml-3.14.2.tgz#77485ce1dd7f33c061fd1b16ecea23b55fcb04b0"
integrity sha512-PMSmkqxr106Xa156c2M265Z+FTrPl+oxd/rgOQy2tijQeK5TxQ43psO1ZCwhVOSdnn+RzkzlRz/eY4BgJBYVpg==
dependencies:
argparse "^1.0.7"
esprima "^4.0.0"

js-yaml@^4.1.0:
version "4.1.0"
resolved "https://registry.npmjs.org/js-yaml/-/js-yaml-4.1.0.tgz"
integrity sha512-wpxZs9NoxZaJESJGIZTyDEaYpl0FKSA+FB9aJiyemKhMwkxQg63h4T1KJgUGHpTqPDNRcmmYLugrRjJlBtWvRA==
dependencies:
argparse "^2.0.1"

json-buffer@3.0.1:
version "3.0.1"
resolved "https://registry.npmjs.org/json-buffer/-/json-buffer-3.0.1.tgz"
Expand Down
Loading