-
Notifications
You must be signed in to change notification settings - Fork 325
Split publish and deploy workflows #4057
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
dskloetc
wants to merge
2
commits into
main
Choose a base branch
from
kloet/publish-workflow
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,133 @@ | ||
| # This workflow publishes docker images to ECR. | ||
| name: Publish | ||
|
|
||
| on: | ||
| push: | ||
| branches: | ||
| - main | ||
| # The only commits that will contain changes to the masterlist will be releases | ||
| paths-ignore: | ||
| - 'MASTERLIST.md' | ||
| - 'package.json' | ||
| - '.changeset/**' | ||
| - 'packages/**/CHANGELOG.md' | ||
| - 'packages/**/README.md' | ||
| - 'packages/**/package.json' | ||
| workflow_dispatch: | ||
| inputs: | ||
| # For this workflow, BUILD_ALL will cause all adapters to have their image built and deployed | ||
| build-all: | ||
| description: whether to run steps for all adapters, regardless of whether they were changed in this event | ||
| required: false | ||
| default: 'false' | ||
|
|
||
| concurrency: | ||
| group: deploy-and-release | ||
| cancel-in-progress: false | ||
|
|
||
| jobs: | ||
| calculate-changes: | ||
| name: Compute changed adapters | ||
| runs-on: [ubuntu-latest] | ||
| permissions: | ||
| contents: read | ||
| outputs: | ||
| adapter-list: ${{ steps.changed-adapters.outputs.CHANGED_ADAPTERS }} | ||
| tmp-branch: ${{ steps.push-branch.outputs.TMP_BRANCH }} | ||
| steps: | ||
| - name: Checkout Repo | ||
| uses: actions/checkout@v4 | ||
| with: | ||
| fetch-depth: 2 | ||
| - name: Set up and install dependencies | ||
| uses: ./.github/actions/setup | ||
| with: | ||
| skip-setup: true | ||
| - name: Build list of changed packages and changed adapters | ||
| id: changed-adapters | ||
| env: | ||
| UPSTREAM_BRANCH: HEAD~1 | ||
| GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} | ||
| run: | | ||
| # The deployment will overwrite existing ones, so in order to calculate all adapters that have been changed, | ||
| # we can mock running the changesets version command to have them present in the diff. | ||
| # Additionally, running the changeset version will cause the images we publish here to have the proper increased version. | ||
| yarn changeset version | ||
|
|
||
| # If there are changes, commit them and calculate the adapters. | ||
| # If there are no changes, we don't need to deploy anything :) | ||
| if [[ `git status --porcelain` ]]; then | ||
| git commit -am "Mock changesets" | ||
| fi | ||
|
|
||
| ./.github/scripts/changed-adapters.sh | ||
| # Since we want to publish with the versions updated, we need to store the changes we've made to a temporary branch | ||
| - name: Publish branch | ||
| id: push-branch | ||
| if: steps.changed-adapters.outputs.CHANGED_ADAPTERS != '[]' | ||
| run: | | ||
| export TMP_BRANCH="tmp-deploy-$(git rev-parse HEAD)" | ||
| git checkout -b tmp-deploy-$(git rev-parse HEAD) | ||
| git push origin tmp-deploy-$(git rev-parse HEAD) | ||
| echo "TMP_BRANCH=$TMP_BRANCH" >> $GITHUB_OUTPUT | ||
|
|
||
| publish-adapter-images: | ||
| name: Build and publish ${{ matrix.adapter.shortName }} | ||
| runs-on: ubuntu-latest | ||
| needs: | ||
| - calculate-changes | ||
| if: needs.calculate-changes.outputs.adapter-list != '[]' | ||
| environment: release | ||
| permissions: # These are needed for the configure-aws-credentials action | ||
| id-token: write | ||
| contents: read | ||
| strategy: | ||
| max-parallel: 20 | ||
| matrix: ${{fromJson(needs.calculate-changes.outputs.adapter-list)}} | ||
| env: | ||
| ECR_URL: ${{ secrets.SDLC_ACCOUNT_ID }}.dkr.ecr.${{ secrets.AWS_REGION_ECR_PRIVATE }}.amazonaws.com | ||
| ECR_REPO: adapters/${{ matrix.adapter.shortName }}-adapter | ||
| IMAGE_VERSION: ${{ matrix.adapter.version }} | ||
| steps: | ||
| - name: Check out code | ||
| uses: actions/checkout@v4 | ||
| with: | ||
| ref: ${{ needs.calculate-changes.outputs.tmp-branch }} | ||
| - name: Build the adapter image | ||
| uses: docker/build-push-action@ca877d9245402d1537745e0e356eab47c3520991 # v6.13.0 | ||
| with: | ||
| context: . | ||
| push: false | ||
| tags: ${{ env.ECR_URL }}/${{ env.ECR_REPO }}:${{ matrix.adapter.version }} | ||
| build-args: | | ||
| package=${{ matrix.adapter.name }} | ||
| location=${{ matrix.adapter.location }} | ||
| - name: Debug | ||
| run: docker image ls | ||
| - name: Publish adapter image | ||
| uses: ./.github/actions/publish-image | ||
| with: | ||
| image-version: ${{ matrix.adapter.version }} | ||
| aws-ecr-url: ${{ env.ECR_URL }} | ||
| aws-ecr-repo: ${{ env.ECR_REPO }} | ||
| aws-region: ${{ secrets.AWS_REGION_ECR_PRIVATE }} | ||
| aws-role: ${{ secrets.AWS_OIDC_IAM_ROLE_ARN }} | ||
| aws-ecr-account-ids: ${{ secrets.AWS_PRIVATE_ECR_SECONDARY_ACCOUNT_ACCESS_IDS }} | ||
| aws-ecr-private: true | ||
| latest: true | ||
|
|
||
| cleanup: | ||
| name: Clean up ephemeral items | ||
| runs-on: ubuntu-latest | ||
| needs: | ||
| - calculate-changes | ||
| - publish-adapter-images | ||
| if: always() && needs.calculate-changes.outputs.adapter-list != '[]' | ||
| steps: | ||
| - name: Check out code | ||
| uses: actions/checkout@v4 | ||
| with: | ||
| ref: ${{ needs.calculate-changes.outputs.tmp-branch }} | ||
| - name: Delete ephemeral branch | ||
| run: | | ||
| git push origin --delete ${{ needs.calculate-changes.outputs.tmp-branch }} | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Check warning
Code scanning / CodeQL
Workflow does not contain permissions Medium
Copilot Autofix
AI 23 days ago
To fix the problem, add an explicit
permissionsblock under thecleanupjob in.github/workflows/publish.yml. This block should specify the minimal required permissions for the steps it performs. Since the job deletes a branch—an operation that requires write access to repository contents—the permissions should be set tocontents: write. This change should be added directly under theruns-onandneedslistings in thecleanupjob (after line 121 and before line 125 for style consistency). No additional imports or dependencies are required.