Opdata 3775 remove view function indexer result decimals #4099
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 45f156a The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
mxiao-cll
reviewed
Oct 14, 2025
| '@chainlink/view-function-multi-chain-adapter': minor | ||
| --- | ||
|
|
||
| USDO PoR EA Update - Remove viewFunctionIndexerResultDecimals input param |
There was a problem hiding this comment.
For major need to add more details on what the NOP should do
mxiao-cll
reviewed
Oct 14, 2025
| } | ||
| } | ||
|
|
||
| async _get_decimals(networkName: string, address: string): Promise<number> { |
There was a problem hiding this comment.
Can you do this instead? Simpler
const abi = [
"function decimals() view returns (uint8)"
];
const token = new ethers.Contract(tokenAddress, abi, provider);
const decimals = await token.decimals();
mxiao-cll
reviewed
Oct 14, 2025
| const [decodedDecimals] = decimalsIface.decodeFunctionResult('decimals', decimalsEncoded) | ||
| decimals = Number(decodedDecimals) | ||
| } catch (err) { | ||
| logger.warn(`Error fetching decimals, defaulting to 0: ${err}`) |
There was a problem hiding this comment.
I don't think defaulting to 0 is the right thing to do, we should prob throw an exception
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #OPDATA-3775
https://smartcontract-it.atlassian.net/browse/OPDATA-3775
Description
Remove viewFunctionIndexerResultDecimals input param
Changes
view-function-multi-chain queries decimals method on contract and returns value in result data
Steps to Test
yarn test packages/source/view-function-multi-chain/test
Quality Assurance
infra-k8sconfiguration file.adapter-secretsconfiguration file or update the soak testing blacklist.test-payload.jsonfile with relevant requests.feature/x,chore/x,release/x,hotfix/x,fix/x) or is created from Jira.