-
Notifications
You must be signed in to change notification settings - Fork 325
[OPDATA-4255] DBAG Tadegate v2 #4120
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
🦋 Changeset detectedLatest commit: 668c6ef The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few changes proposed and can we please fix the integration tests to run so that we can early fail any issues?
packages/sources/deutsche-boerse/src/endpoint/lwbaLatestPrice.ts
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good now, just one last nitpick and can you please rebase to make sure we have the latest from DBAG?
packages/sources/deutsche-boerse/src/transport/instrument-quote-cache.ts
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few nits but not blockers.
Thank you!
logger.debug({ isin, market }, 'Awaiting complete quote before emitting') | ||
const responseData = extractData(quote, providerTime) | ||
if (!responseData) { | ||
logger.debug({ isin, market }, 'Awaiting complete data before emitting') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This log as well
668c6ef
Closes https://smartcontract-it.atlassian.net/browse/OPDATA-4247
Description
bidSz
andaskSz
{market}-{instrument}
avgPx
for lastPxSteps to Test
Quality Assurance
infra-k8s
configuration file.adapter-secrets
configuration file or update the soak testing blacklist.test-payload.json
file with relevant requests.feature/x
,chore/x
,release/x
,hotfix/x
,fix/x
) or is created from Jira.