Skip to content

Remove logs that reveal report/observation payload & cosmetic OCR3 changes #78

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Remove logs that reveal report/observation payload & cosmetic OCR3 changes #78

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions offchainreporting2plus/internal/managed/managed_mercury_oracle.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -125,13 +125,13 @@ func RunManagedMercuryOracle(

reportingPluginLimits := mercuryshim.ReportingPluginLimits(mercuryPluginInfo.Limits)

lims, err := limits.OCR3Limits(sharedConfig.PublicConfig, reportingPluginLimits, onchainKeyring.MaxSignatureLength())
lims, err := limits.OCR3Limits(sharedConfig.PublicConfig, reportingPluginLimits, ocr3OnchainKeyring.MaxSignatureLength())
if err != nil {
logger.Error("ManagedMercuryOracle: error during limits", commontypes.LogFields{
"error": err,
"publicConfig": sharedConfig.PublicConfig,
"reportingPluginLimits": reportingPluginLimits,
"maxSigLen": onchainKeyring.MaxSignatureLength(),
"maxSigLen": ocr3OnchainKeyring.MaxSignatureLength(),
})
return
}
Expand All @@ -157,7 +157,7 @@ func RunManagedMercuryOracle(
chTelemetrySend,
sharedConfig.ConfigDigest,
binNetEndpoint,
onchainKeyring.MaxSignatureLength(),
ocr3OnchainKeyring.MaxSignatureLength(),
childLogger,
reportingPluginLimits,
sharedConfig.N(),
Expand Down
3 changes: 1 addition & 2 deletions offchainreporting2plus/internal/ocr2/protocol/report_generation_follower.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -170,8 +170,7 @@ func (repgen *reportGenerationState) messageObserveReq(msg MessageObserveReq, se
}

repgen.logger.Debug("sent observation to leader", commontypes.LogFields{
"round": repgen.followerState.r,
"observation": o,
"round": repgen.followerState.r,
})
repgen.netSender.SendTo(MessageObserve{
repgen.e,
Expand Down
3 changes: 1 addition & 2 deletions offchainreporting2plus/internal/ocr2/protocol/report_generation_leader.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -312,8 +312,7 @@ func (repgen *reportGenerationState) messageReport(msg MessageReport, sender com
})
} else if !report.Skip && !msg.AttestedReport.Skip { // oracles may commonly disagree on whether to skip, no need to warn about that
repgen.logger.Warn("received disparate reports messages", commontypes.LogFields{
"round": repgen.leaderState.r,
"previousReport": report,
"round": repgen.leaderState.r,
})
}
}
Expand Down
3 changes: 2 additions & 1 deletion offchainreporting2plus/internal/ocr3/protocol/common.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,8 @@ func callPlugin[T any](
maxDuration+ReportingPluginTimeoutWarningGracePeriod,
func() {
logger.MakeChild(logFields).Error(fmt.Sprintf("call to ReportingPlugin.%s is taking too long", name), commontypes.LogFields{
"maxDuration": maxDuration,
"maxDuration": maxDuration.String(),
"gracePeriod": ReportingPluginTimeoutWarningGracePeriod.String(),
})
},
)
Expand Down