-
Notifications
You must be signed in to change notification settings - Fork 1
Add TON support #486
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Add TON support #486
Conversation
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is nix mandatory for ton?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey! Nix is added to support dev environments for devs that use Nix.
Nix is also the way to get chainlink-ton packages, in this case I will need the TON contracts
package, which I can easily pull from source with Nix. This is required to deploy contracts.
Same as we import Go bindings from a commit with Go,
we import TON contract artifacts from a commit with Nix.
Nix is an orthogonal add-on - this means that folks can use it or set up things manually.
For TON, some tools like Go need to be in a path and TON compiled contracts need to be available on a path defined with an env var. One can just run a prepared Nix shell to get all of that, or set up things manually.
Once I get everything working, I will also document how to get a TON env running manually as well.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have a few requests, if you please.
- add a changeset file
- remove the .envrc file. We don't mind if you want to use nix, but we don't want to enforce it by default
- consider adding unit tests; I understand it's just an initial PR, but we do try have good coverage in the library. Ideally, in every PR.
I see the PR was marked as draft later... If it's not ready for review yet, please ignore my remarks. |
Thx for a quick review! Yeah, still an early draft trying to move things forward. |
No description provided.