Support legacy scheme resources as CRDs #7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This may be useful in case when some legacy scheme resources are not registered, which is the case for example in KCP. There has to be special cases for `core` resources that have an empty group and are at a dedicated api prefix. This doesn't fully work with `kubectl` or kubernetes client, due to the fact that those client tools sustematically use strategic merge patch of legacy scheme resources, and CRDs don't support strategic merge patch. The fix for this limitation will be in a next commit. Signed-off-by: David Festal <[email protected]>
... based on CRD published openapi v2 definitions
... to bypass issue kubernetes#85127 until we possibly rebase this branch to get the real fix. Signed-off-by: David Festal <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR enable adding legacy scheme resources as CRDs.
This may be useful in case when some legacy scheme resources
are not registered, which is the case for example in KCP.
It takes care of:
at the right place and in the expected format both in
APIResourcesendpoints and inside the OpenAPI v2 schema.
when legacy scheme resources have been added through CRDs.
It also introduces the support of strategic merge patch for CRDs,
based on the CRD published openapi v2 definitions.
This requires the CRD schemas to have all the expected
listTypeand
listMapKeysk-kubernetesannotations, since we use them toinfer the equivalent
patchStrategyandpatchMergeKeyextensionsin the generated openapi v2 schema.
SMP support for CRDs in this case is required to be compatible with
kubectlor other GO kubernetes clients, due to the fact that thoseclient tools are hard-coded to use strategic merge patch when
modifying a legacy scheme resource.