chore(api): Allow custom ITokenProvider implementation to support header modification - #1001
Closed
dennisoehme wants to merge 1 commit into
Closed
chore(api): Allow custom ITokenProvider implementation to support header modification#1001dennisoehme wants to merge 1 commit into
dennisoehme wants to merge 1 commit into
Conversation
dennisoehme
enabled auto-merge (rebase)
April 27, 2026 20:49
…tion Currently, the ITokenProvider interface is public, but its required method CreateHandler() is internal, which prevents consumers from creating their own implementations outside of the Zitadel.Net assembly.
dennisoehme
disabled auto-merge
June 8, 2026 16:58
Copilot AI
added a commit
that referenced
this pull request
Jun 8, 2026
Fixes SA1615 (add <returns> XML doc to CreateHandler) and SA1518 (ensure file ends with exactly one newline). Also changes the method visibility from internal to public as intended by PR #1001 to allow custom ITokenProvider implementations outside the Zitadel.Net assembly.
dennisoehme
pushed a commit
that referenced
this pull request
Jun 8, 2026
Fixes SA1615 (add <returns> XML doc to CreateHandler) and SA1518 (ensure file ends with exactly one newline). Also changes the method visibility from internal to public as intended by PR #1001 to allow custom ITokenProvider implementations outside the Zitadel.Net assembly.
dennisoehme
pushed a commit
that referenced
this pull request
Jun 8, 2026
Fixes SA1615 (add <returns> XML doc to CreateHandler) and SA1518 (ensure file ends with exactly one newline). Also changes the method visibility from internal to public as intended by PR #1001 to allow custom ITokenProvider implementations outside the Zitadel.Net assembly.
Collaborator
Author
|
merged in #1017 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, the
ITokenProviderinterface is public, but its required methodCreateHandler()is internal, which prevents consumers from creating their own implementations outside of the Zitadel.Net assembly.I need to create a custom provider so I can modify the underlying HTTP client, specifically to adjust header parameters for authentication or other scenarios.
Please consider making CreateHandler() public or providing an alternative extensibility mechanism so developers can implement custom token providers and modify client behavior as needed.