Shipping Block Extension #49
Conversation
Options are being displayed in the frontend but there values stored in the order details part remaining
There was a problem hiding this comment.
First of all, formatting of all files must be performed. Please use the wordpress coding standards to format all files according to standard.
Secondly then it seems there are way too many files in this PR. My guess is there is a lot of boilerplate/copy that can easily be deleted?
Note that in many places then there is a lot of naming (file name/namespace/folder/variables) like shipping-workshop and alternateShippingInstruction which is clearely a leftover from copying from another plugin. These names should be adjusted to what this is "pickup-point"
| "apiVersion": 3, | ||
| "name": "create-block/shipping-workshop", | ||
| "version": "1.0.0", | ||
| "title": "Shipping Workshop", |
There was a problem hiding this comment.
The title should be the displayed name.
Consider something like:
| "title": "Shipping Workshop", | |
| "title": "Pick-up Point checkout", |
| { | ||
| "$schema": "https://schemas.wp.org/trunk/block.json", | ||
| "apiVersion": 3, | ||
| "name": "create-block/shipping-workshop", |
There was a problem hiding this comment.
This name does not follow the specs: https://developer.wordpress.org/block-editor/reference-guides/block-api/block-metadata/#name
The name for a block is a unique string that identifies a block. Names have to be structured as
namespace/block-name, where namespace is the name of your plugin or theme.
| "name": "create-block/shipping-workshop", | |
| "name": "smart-send/pick-up-points", |
| "version": "1.0.0", | ||
| "title": "Shipping Workshop", | ||
| "category": "widgets", | ||
| "icon": "palmtree", |
There was a problem hiding this comment.
| "icon": "palmtree", | |
| "icon": "list-view", |
| "title": "Shipping Workshop", | ||
| "category": "widgets", | ||
| "icon": "palmtree", | ||
| "textdomain": "shipping-workshop", |
There was a problem hiding this comment.
This needs to match the plugin's Text Domain
| "textdomain": "shipping-workshop", | |
| "textdomain": "smart-send-logistics", |
| "name": "create-block/shipping-workshop", | ||
| "version": "1.0.0", | ||
| "title": "Shipping Workshop", | ||
| "category": "widgets", |
There was a problem hiding this comment.
Add a description:
| "category": "widgets", | |
| "description": "Show pick-up point selector during checkout for relevant shipping methods" | |
| "category": "widgets", |
| city, | ||
| street | ||
| ) { | ||
| // Sanitize inputs |
| { | ||
| "apiVersion": 2, | ||
| "name": "shipping-workshop/shipping-workshop-block", | ||
| "version": "2.0.0", | ||
| "title": "Alternative Shipping Options Block", | ||
| "category": "woocommerce", | ||
| "description": "Adds a select field to let the shopper choose alternative shipping instructions.", | ||
| "supports": { | ||
| "html": false, | ||
| "align": false, | ||
| "multiple": false, | ||
| "reusable": false | ||
| }, | ||
| "parent": [ "woocommerce/checkout-shipping-methods-block" ], | ||
| "attributes": { | ||
| "lock": { | ||
| "type": "object", | ||
| "default": { | ||
| "remove": true, | ||
| "move": true | ||
| } | ||
| }, | ||
| "text": { | ||
| "type": "string", | ||
| "default": "" | ||
| } | ||
| }, | ||
| "textdomain": "shipping-workshop", | ||
| "editorStyle": "file:../../../build/style-shipping-workshop-block.css" | ||
| } |
There was a problem hiding this comment.
All of this need to be adjusted. This is copyed from somewhere else and not adjusted. The apiVersion is also old?
There was a problem hiding this comment.
This file, shipping-workshop-block/edit.js, is used for adding fields or options to the shipping workshop block in the dashboard's block editor. It defines the editing interface for the block, allowing users to configure various settings and options related to the "smart_send" logistics shipping method. This includes rendering the necessary input fields, handling user interactions, and updating the block's state as users make changes.
There was a problem hiding this comment.
Is this file actually used or a left over? There is also a src/js/shipping-workshop-block/block.json file?
There was a problem hiding this comment.
The smart-send-logistics/block.json file is indeed used and not a leftover. It is responsiblefor registering the main shipping workshop block in WooCommerce and informing WordPress about the block's associated script and style files. This ensures that the block is properly integrated and functional within the WordPress and WooCommerce environments.On the other hand, the src/js/shipping-workshop-block/block.json file is used to define the inner blocks, their specific configurations, and essential details. This file provides information necessary for the proper rendering and behaviour of the inner blocks within the shipping workshop block.Both files are crucial for the correct setup and operation of the shipping workshop block and its components.
There was a problem hiding this comment.
The smart-send-logistics/src/js/style.scss file is used to define the styles for the frontend of our block. This SCSS (Sass) file contains the styling rules that determine the appearance and layout of the shipping workshop block when it is rendered on the website. It ensures that the block is visually consistent with the overall design of the site and provides a better user experience by applying custom styles such as colors, fonts, spacing, and other CSS properties.
Options are being displayed in the frontend but there values stored in the order details part remaining