Only load quickedit resources on quickedit view. - #201
Open
dhavlik wants to merge 2 commits into
Open
Conversation
Sometimes the people using the form are members, but can't edit the form. Before this change, the form looks ugly for them, taking only half the available space. Quickedit only needed in quickedit view.
mauritsvanrees
requested changes
Oct 17, 2017
mauritsvanrees
left a comment
mauritsvanrees
left a comment
Collaborator
There was a problem hiding this comment.
Seems okay.
I wondered if it might be better to change the quick edit page template and explicitly load it there instead, so we can remove it from the registry. But that is less good for caching.
This does need an upgrade step though, otherwise existing installations will still have the old settings.
And can you add an entry in CHANGES.txt?
Collaborator
|
An upgrade step is missing. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sometimes the people using the form are members, but can't edit the form. Before this change, the form looks ugly for them, taking only half the available space. Quickedit only needed in quickedit view.