Skip to content

Conversation

@wangerekaharun
Copy link
Member

@wangerekaharun wangerekaharun commented Dec 8, 2025

User description

Story: https://app.shortcut.com/smileid/story/xxx

Summary

A few sentences/bullet points about the changes

Known Issues

Any shortcomings in your work. This may include corner cases not correctly handled or issues related
to but not within the scope of your PR. Design compromises should be discussed here if they were not
already discussed above.

Test Instructions

Concise test instructions on how to verify that your feature works as intended. This should include
changes to the development environment (if applicable) and all commands needed to run your work.

Screenshot

If applicable (e.g. UI changes), add screenshots to help explain your work.


PR Type

Enhancement, Documentation


Description

  • Bump Android SDK to v11.1.4 and iOS SDK to v11.1.3

  • Add workaround for iOS Swift module interface verification error

  • Improve iOS CI build process with Xcode 16.4 and simulator configuration

  • Update wrapper SDK version to 11.2.1 across platforms


File Walkthrough

Relevant files
Enhancement
2 files
SmileIDExpoModule.kt
Update wrapper SDK version to 11.2.1                                         
+1/-1     
SmileIDExpoModule.swift
Update wrapper SDK version to 11.2.1                                         
+1/-1     
Dependencies
1 files
SmileIDExpo.podspec
Bump SmileID iOS dependency to 11.1.3                                       
+1/-1     
Configuration changes
2 files
ci.yml
Enhance iOS build with Xcode 16.4 and Swift module workaround
+24/-26 
project.pbxproj
Update Xcode project framework and resource references     
+4/-6     
Documentation
2 files
CHANGELOG.md
Document SDK version bumps and iOS build fix                         
+9/-0     
README.md
Add troubleshooting section for iOS Swift module error     
+35/-0   
Bug fix
1 files
Podfile
Disable BUILD_LIBRARY_FOR_DISTRIBUTION for SmileID pods   
+22/-0   


Need help?
  • Type /help how to ... in the comments thread for any questions about PR-Agent usage.
  • Check out the documentation for more information.
  • @wangerekaharun wangerekaharun marked this pull request as ready for review December 8, 2025 20:50
    @prfectionist
    Copy link
    Contributor

    prfectionist bot commented Dec 8, 2025

    PR Reviewer Guide 🔍

    Here are some key observations to aid the review process:

    ⏱️ Estimated effort to review: 2 🔵🔵⚪⚪⚪
    🧪 No relevant tests
    🔒 No security concerns identified
    ⚡ Recommended focus areas for review

    Build Configuration

    The iOS build now disables Swift module interface verification (SWIFT_EMIT_MODULE_INTERFACE=NO) and library distribution (BUILD_LIBRARY_FOR_DISTRIBUTION=NO) as a workaround. This should be validated to ensure it doesn't affect the final SDK functionality or distribution capabilities. Consider whether this workaround is appropriate for CI builds versus production builds.

    xcodebuild \
      -workspace "$WORKSPACE" \
      -scheme "$APP_SCHEME" \
      -configuration Debug \
      -destination "generic/platform=iOS Simulator" \
      -skipPackagePluginValidation \
      -skipMacroValidation \
      CODE_SIGNING_ALLOWED=NO \
      CODE_SIGNING_REQUIRED=NO \
      COMPILER_INDEX_STORE_ENABLE=NO \
      SWIFT_TREAT_WARNINGS_AS_ERRORS=NO \
      GCC_TREAT_WARNINGS_AS_ERRORS=NO \
      BUILD_LIBRARY_FOR_DISTRIBUTION=NO \
      SWIFT_EMIT_MODULE_INTERFACE=NO \
      build 2>&1 | tee "$BUILD_LOG"
    Duplicate Configuration

    The post_install block applies the same BUILD_LIBRARY_FOR_DISTRIBUTION=NO setting twice - once iterating through pods_project.targets and again through generated_projects. This duplication may be unnecessary and could cause confusion. Verify if both iterations are needed or if one is sufficient.

    # Disable BUILD_LIBRARY_FOR_DISTRIBUTION for SmileID to avoid Swift module interface verification errors
    # This must be done for all targets that might have it enabled
    installer.pods_project.targets.each do |target|
      if ['SmileID', 'SmileIDSDK'].include?(target.name)
        target.build_configurations.each do |config|
          config.build_settings['BUILD_LIBRARY_FOR_DISTRIBUTION'] = 'NO'
          config.build_settings['SWIFT_SERIALIZE_DEBUGGING_OPTIONS'] = 'NO'
        end
      end
    end
    
    # Also apply to all pod targets via build settings
    installer.generated_projects.each do |project|
      project.targets.each do |target|
        target.build_configurations.each do |config|
          if target.name.include?('SmileID')
            config.build_settings['BUILD_LIBRARY_FOR_DISTRIBUTION'] = 'NO'
          end
        end
      end
    end

    @prfectionist
    Copy link
    Contributor

    prfectionist bot commented Dec 8, 2025

    PR Code Suggestions ✨

    No code suggestions found for the PR.

    @wangerekaharun wangerekaharun changed the title Feat: Bump Android SDK to v11.1.4 and iOS to v11.1.3 Feat: Bump Android SDK to v11.1.6 and iOS to v11.1.5 Dec 23, 2025
    @wangerekaharun wangerekaharun merged commit 6e8fd08 into main Dec 23, 2025
    6 checks passed
    @wangerekaharun wangerekaharun deleted the feat/ios-release branch December 23, 2025 16:22
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

    Projects

    None yet

    Development

    Successfully merging this pull request may close these issues.

    2 participants