-
Notifications
You must be signed in to change notification settings - Fork 3
Add translation to enhanced document verification #521
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Support bundled languages
Update embed iframes to set current locale
extract strings from signature and navigation screens
Co-authored-by: prfectionist[bot] <187910262+prfectionist[bot]@users.noreply.github.com>
remove duplicate translation keys
PR Reviewer Guide 🔍Here are some key observations to aid the review process:
|
|
This branch has been deployed to s3 / cloudfront. ✅ Preview URL for Smart Camera Web: |
beastawakens
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
PR Type
Enhancement
Description
Add internationalization support to enhanced document verification flow
Implement dynamic translation for UI elements using
data-i18nattributesAdd RTL language support with automatic text direction detection
Update locale files with new translation keys for ID selection and error pages
File Walkthrough
enhanced-document-verification.js
Implement translation system and replace hardcoded stringspackages/embed/src/js/enhanced-document-verification.js
translate,getDirection) fromlocalisation module
applyPageTranslations()function to translate elements withdata-i18nattributesinitialization
translate()calls for ID selectionplaceholders and error messages
enhanced-document-verification.html
Add translation attributes to HTML elementspackages/embed/src/enhanced-document-verification.html
data-i18nattributes to all user-facing text elements across allscreens
with translation keys
ar-EG.json
Clean up duplicates and add Arabic translation keypackages/web-components/locales/ar-EG.json
fileUploaderror translation blockselectCountryFirsttranslation key topages.idSelectionsectionen-GB.json
Clean up duplicates and add English translation keypackages/web-components/locales/en-GB.json
fileUploaderror translation blockselectCountryFirsttranslation key topages.idSelectionsection