feat: Better .NET type conversion encapsulation #728
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
josecorella
force-pushed
the
seebees/net-type-conversion-encapsulation
branch
from
884b6bc to
34f5452
Compare
Dafny has optional parameters. Smithy-Dafny uses this feature to produce Dafny types that default to `:= None`. However, the translated Dafny does *not* support optional parameters. This means that these optional parameters, are _not_ interoperable in target runtimes. .NET already deferred type conversions of wrapped resources to the target module. But it assumed that Dafny was overly interoperable. This change to .NET defers all type conversion to the module that owns the type. This brings .NET more in line with other runtimes. This change is not completely backwards compatible. There are a few edge cases with orphaned types as well as already published versions.
josecorella
force-pushed
the
seebees/net-type-conversion-encapsulation
branch
from
756ce36 to
95adb6d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dafny has optional parameters.
Smithy-Dafny uses this feature
to produce Dafny types
that default to
:= None.However, the translated Dafny
does not support optional parameters.
This means that these optional parameters,
are not interoperable in target runtimes.
.NET already deferred type conversions
of wrapped resources to the target module.
But it assumed that Dafny was overly interoperable.
This change to .NET defers all type conversion
to the module that owns the type.
This brings .NET more in line with other runtimes.
This change is not completely backwards compatible.
There are a few edge cases with orphaned types
as well as already published versions.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.